]> Cypherpunks repositories - gostls13.git/commitdiff
os: skip TestStartProcess and TestHostname on android
authorMikio Hara <mikioh.mikioh@gmail.com>
Thu, 18 Jun 2015 01:44:52 +0000 (10:44 +0900)
committerMikio Hara <mikioh.mikioh@gmail.com>
Fri, 19 Jun 2015 00:32:01 +0000 (00:32 +0000)
Updates #11268.

Change-Id: Ib0cabd1c1806e884df9e40f6a9a1cdecf2f76823
Reviewed-on: https://go-review.googlesource.com/11223
Reviewed-by: David Crawshaw <crawshaw@golang.org>
src/os/os_test.go

index afb30fd84480a9529dc1f83a808b64d33bb9cb95..09856412dfe30b84a0f6501e916d2fde68149728 100644 (file)
@@ -799,11 +799,14 @@ func TestStartProcess(t *testing.T) {
 
        var dir, cmd string
        var args []string
-       if runtime.GOOS == "windows" {
+       switch runtime.GOOS {
+       case "android":
+               t.Skip("android doesn't have /bin/pwd")
+       case "windows":
                cmd = Getenv("COMSPEC")
                dir = Getenv("SystemRoot")
                args = []string{"/c", "cd"}
-       } else {
+       default:
                cmd = "/bin/pwd"
                dir = "/"
                args = []string{}
@@ -1252,8 +1255,8 @@ func TestHostname(t *testing.T) {
        // There is no other way to fetch hostname on windows, but via winapi.
        // On Plan 9 it can be taken from #c/sysname as Hostname() does.
        switch runtime.GOOS {
-       case "plan9":
-               t.Skipf("skipping on %s", runtime.GOOS)
+       case "android", "plan9":
+               t.Skipf("%s doesn't have /bin/hostname", runtime.GOOS)
        case "windows":
                testWindowsHostname(t)
                return