]> Cypherpunks repositories - gostls13.git/commitdiff
net: skip TestLookupPTR when LookupAddr fails with "DNS server failure"
authorBryan C. Mills <bcmills@google.com>
Fri, 2 Sep 2022 15:36:46 +0000 (11:36 -0400)
committerGopher Robot <gobot@golang.org>
Sat, 3 Sep 2022 18:19:12 +0000 (18:19 +0000)
For #38111.

Change-Id: I43bdd756bde0adcd156cf9750b49b3b989304df7
Reviewed-on: https://go-review.googlesource.com/c/go/+/427915
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>

src/net/lookup_windows_test.go

index b7a60e1278f76a210cc0399aae61bd4463aef1a3..20e0a1a8f175adb88b3e9c7ae4d7b49406e2ce58 100644 (file)
@@ -16,6 +16,7 @@ import (
        "regexp"
        "sort"
        "strings"
+       "syscall"
        "testing"
 )
 
@@ -171,6 +172,14 @@ func TestLookupPTR(t *testing.T) {
        for _, addr := range lookupTestIPs {
                names, err := LookupAddr(addr)
                if err != nil {
+                       // The DNSError type stores the error as a string, so it cannot wrap the
+                       // original error code and we cannot check for it here. However, we can at
+                       // least use its error string to identify the correct localized text for
+                       // the error to skip.
+                       var DNS_ERROR_RCODE_SERVER_FAILURE syscall.Errno = 9002
+                       if strings.HasSuffix(err.Error(), DNS_ERROR_RCODE_SERVER_FAILURE.Error()) {
+                               testenv.SkipFlaky(t, 38111)
+                       }
                        t.Errorf("failed %s: %s", addr, err)
                }
                if len(names) == 0 {