]> Cypherpunks repositories - gostls13.git/commitdiff
net/url: fail TestParseErrors test when getting an unwanted error
authorStefan Baebler <sbaebler@outbrain.com>
Wed, 7 Aug 2019 14:16:59 +0000 (14:16 +0000)
committerEmmanuel Odeke <emm.odeke@gmail.com>
Tue, 27 Aug 2019 16:55:43 +0000 (16:55 +0000)
The TestParseErrors test function was not strict with unwanted errors
received from url.Parse(). It was not failing in such cases, now it does.

Change-Id: I18a26a68c1136f5c762989a76e04b47e33dd35f1
GitHub-Last-Rev: c33f9842f7908f27012859e25caa79388cc2785a
GitHub-Pull-Request: golang/go#32954
Reviewed-on: https://go-review.googlesource.com/c/go/+/185080
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/net/url/url_test.go

index e83c86c424324e7b77b9598cc9bc6ff0709ba527..b86956906d845db1dd6c7f3f441a3a16d49eee0d 100644 (file)
@@ -1456,7 +1456,7 @@ func TestParseErrors(t *testing.T) {
                        continue
                }
                if err != nil {
-                       t.Logf("Parse(%q) = %v; want no error", tt.in, err)
+                       t.Errorf("Parse(%q) = %v; want no error", tt.in, err)
                }
        }
 }