]> Cypherpunks repositories - gostls13.git/commitdiff
Revert "cmd/compile: ignore g register in liveness analysis"
authorAustin Clements <austin@google.com>
Tue, 22 May 2018 21:33:23 +0000 (17:33 -0400)
committerAustin Clements <austin@google.com>
Thu, 31 May 2018 14:50:57 +0000 (14:50 +0000)
This reverts commit ea200340702cf3ccfac7c5db1f11bb65c80971c7 now
that CL 114695 fixed the root cause of #25504.

Change-Id: If437fc832983bd8793bde28ce0e2e64436a0596c
Reviewed-on: https://go-review.googlesource.com/114087
Reviewed-by: David Chase <drchase@google.com>
src/cmd/compile/internal/gc/plive.go

index f3f1ca3d397e6bc7826486775e662e5d9210c734..88b438063709297aeb23d23d8ca2d30e3a7c1a22 100644 (file)
@@ -461,17 +461,6 @@ func (lv *Liveness) regEffects(v *ssa.Value) (uevar, kill liveRegMask) {
                for _, reg := range regs[:nreg] {
                        if reg.GCNum() == -1 {
                                if ptrOnly {
-                                       if reg.String() == "g" {
-                                               // Issue #25504: Sometimes we
-                                               // spill and reload the g
-                                               // register, which this sees
-                                               // as a pointer load into the
-                                               // g register. The g register
-                                               // isn't a GP register and
-                                               // can't appear in register
-                                               // maps. Ignore it.
-                                               continue
-                                       }
                                        v.Fatalf("pointer in non-pointer register %v", reg)
                                } else {
                                        continue