]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/cgo/internal/testshared: skip in short mode and not on builders
authorCherry Mui <cherryyz@google.com>
Thu, 20 Jul 2023 18:21:07 +0000 (14:21 -0400)
committerCherry Mui <cherryyz@google.com>
Fri, 21 Jul 2023 15:03:06 +0000 (15:03 +0000)
We already skip testcarchive, testcshared, and testplugin in short
mode and not on builders. The shared build mode is not more
supported than the c-archive, c-shared, and plugin build modes. No
need to run it everywhere by default.

Updates #61025.

Change-Id: I6a06e04c1a1dc78f0f85456320d128bd67277915
Reviewed-on: https://go-review.googlesource.com/c/go/+/511696
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
src/cmd/cgo/internal/testshared/shared_test.go

index 796c46b9bf742caf8e6c39375a158fdcd6aca83a..2eab33f9191b7c3f60661fb229d44d5d805f9270 100644 (file)
@@ -96,6 +96,10 @@ func goCmd(t *testing.T, args ...string) string {
 
 // TestMain calls testMain so that the latter can use defer (TestMain exits with os.Exit).
 func testMain(m *testing.M) (int, error) {
+       if testing.Short() && os.Getenv("GO_BUILDER_NAME") == "" {
+               globalSkip = func(t testing.TB) { t.Skip("short mode and $GO_BUILDER_NAME not set") }
+               return m.Run(), nil
+       }
        if !platform.BuildModeSupported(runtime.Compiler, "shared", runtime.GOOS, runtime.GOARCH) {
                globalSkip = func(t testing.TB) { t.Skip("shared build mode not supported") }
                return m.Run(), nil