]> Cypherpunks repositories - gostls13.git/commitdiff
misc/cgo/test: add test that gccgo fails
authorXia Bin <snyh@snyh.org>
Sun, 24 Jan 2016 06:22:54 +0000 (14:22 +0800)
committerRuss Cox <rsc@golang.org>
Thu, 13 Oct 2016 00:03:57 +0000 (00:03 +0000)
Gccgo isn't locking the OS thread properly during calls.

Change-Id: Idb2475291405e390cbb83abb27a402fd0381d0c4
Reviewed-on: https://go-review.googlesource.com/18882
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
misc/cgo/test/basic.go
misc/cgo/test/cgo_test.go
misc/cgo/test/cgo_thread_lock.go [new file with mode: 0644]

index 2189af6ae4c545fff30a41ce5a0da25609713e98..3ceb4ce8470d4dac938c5741dcc19932db6616d4 100644 (file)
@@ -162,3 +162,6 @@ func testUnsignedInt(t *testing.T) {
 func sliceOperands(array [2000]int) {
        _ = array[C.KILO:C.KILO:C.KILO] // no type error
 }
+
+// set in cgo_thread_lock.go init
+var testThreadLockFunc = func(*testing.T) {}
index 362c64072883c7f27789060222046c80f4a484a0..8746f9099481aedc74cbcf2f9ac57ef5d2890bd3 100644 (file)
@@ -72,5 +72,6 @@ func TestCallGoWithString(t *testing.T)      { testCallGoWithString(t) }
 func Test14838(t *testing.T)                 { test14838(t) }
 func Test8756(t *testing.T)                  { test8756(t) }
 func Test17065(t *testing.T)                 { test17065(t) }
+func TestThreadLock(t *testing.T)            { testThreadLockFunc(t) }
 
 func BenchmarkCgoCall(b *testing.B) { benchCgoCall(b) }
diff --git a/misc/cgo/test/cgo_thread_lock.go b/misc/cgo/test/cgo_thread_lock.go
new file mode 100644 (file)
index 0000000..b105068
--- /dev/null
@@ -0,0 +1,53 @@
+// Copyright 2016 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// +build linux,freebsd,openbsd
+
+package cgotest
+
+/*
+#include <unistd.h>
+#include <sys/syscall.h>
+void Gosched(void);
+static int Ctid(void) { Gosched(); return syscall(SYS_gettid); }
+*/
+import "C"
+
+import (
+       "runtime"
+       "syscall"
+       "testing"
+       "time"
+)
+
+//export Gosched
+func Gosched() {
+       runtime.Gosched()
+}
+
+func init() {
+       testThreadLockFunc = testThreadLock
+}
+
+func testThreadLock(t *testing.T) {
+       stop := make(chan int)
+       go func() {
+               // We need the G continue running,
+               // so the M has a chance to run this G.
+               for {
+                       select {
+                       case <-stop:
+                               return
+                       case <-time.After(time.Millisecond * 100):
+                       }
+               }
+       }()
+       defer close(stop)
+
+       for i := 0; i < 1000; i++ {
+               if C.int(syscall.Gettid()) != C.Ctid() {
+                       t.Fatalf("cgo has not locked OS thread")
+               }
+       }
+}