cmd/internal/obj/x86: minor code cleanup

Update #16415

Change-Id: I83e0966931ada2f1ed02304685bb45effdd71268
Reviewed-on: https://go-review.googlesource.com/26665
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

diff --git a/src/cmd/internal/obj/x86/obj6.go b/src/cmd/internal/obj/x86/obj6.go
index 93fee97e4b3159df7dab3794b40d43b5bfa6b52c..b400d457671f7431b0128e453a31bce470edb183 100644 (file)
--- a/src/cmd/internal/obj/x86/obj6.go
+++ b/src/cmd/internal/obj/x86/obj6.go
@@ -833,31 +833,26 @@ func preprocess(ctxt *obj.Link, cursym *obj.LSym) {
                p2.Pcond = p
        }
 
-       var a int
-       var pcsize int
        for ; p != nil; p = p.Link {
-               pcsize = int(p.Mode) / 8
-               a = int(p.From.Name)
-               if a == obj.NAME_AUTO {
+               pcsize := int(p.Mode) / 8
+               switch p.From.Name {
+               case obj.NAME_AUTO:
                        p.From.Offset += int64(deltasp) - int64(bpsize)
-               }
-               if a == obj.NAME_PARAM {
+               case obj.NAME_PARAM:
                        p.From.Offset += int64(deltasp) + int64(pcsize)
                }
                if p.From3 != nil {
-                       a = int(p.From3.Name)
-                       if a == obj.NAME_AUTO {
+                       switch p.From3.Name {
+                       case obj.NAME_AUTO:
                                p.From3.Offset += int64(deltasp) - int64(bpsize)
-                       }
-                       if a == obj.NAME_PARAM {
+                       case obj.NAME_PARAM:
                                p.From3.Offset += int64(deltasp) + int64(pcsize)
                        }
                }
-               a = int(p.To.Name)
-               if a == obj.NAME_AUTO {
+               switch p.To.Name {
+               case obj.NAME_AUTO:
                        p.To.Offset += int64(deltasp) - int64(bpsize)
-               }
-               if a == obj.NAME_PARAM {
+               case obj.NAME_PARAM:
                        p.To.Offset += int64(deltasp) + int64(pcsize)
                }
 
@@ -896,7 +891,7 @@ func preprocess(ctxt *obj.Link, cursym *obj.LSym) {
                        continue
 
                case obj.ARET:
-                       break
+                       // do nothing
                }
 
                if autoffset != deltasp {