]> Cypherpunks repositories - gostls13.git/commitdiff
net: report connect error as coming from "connect"
authorIan Lance Taylor <iant@golang.org>
Wed, 3 Jan 2018 18:09:35 +0000 (10:09 -0800)
committerIan Lance Taylor <iant@golang.org>
Wed, 3 Jan 2018 19:30:48 +0000 (19:30 +0000)
We retrieve an error using getsockopt with SO_ERROR. We were reporting
the error as coming from "getsockopt", but really it is coming from
"connect". It is not getsockopt that failed.

Fixes #19302

Change-Id: I510ab76e4b04c70cd9dfdfc46d9a410bf653d017
Reviewed-on: https://go-review.googlesource.com/85997
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/net/fd_unix.go

index 87486578af46d71800f9500f3c0302ab25a2d251..dd3c1ed88203b7a31bf2fb0dea02336d70879d09 100644 (file)
@@ -173,7 +173,7 @@ func (fd *netFD) connect(ctx context.Context, la, ra syscall.Sockaddr) (rsa sysc
                                return rsa, nil
                        }
                default:
-                       return nil, os.NewSyscallError("getsockopt", err)
+                       return nil, os.NewSyscallError("connect", err)
                }
                runtime.KeepAlive(fd)
        }