]> Cypherpunks repositories - gostls13.git/commitdiff
cmd: fix mismatched symbols
authorcui fliter <imcusg@gmail.com>
Mon, 2 Oct 2023 07:09:26 +0000 (15:09 +0800)
committerGopher Robot <gobot@golang.org>
Tue, 3 Oct 2023 12:57:25 +0000 (12:57 +0000)
Change-Id: I6365cdf22ad5e669908519d0ee8b78d76ae8f1b9
Reviewed-on: https://go-review.googlesource.com/c/go/+/532075
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: shuang cui <imcusg@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
src/cmd/covdata/doc.go
src/cmd/cover/doc.go
src/cmd/go/internal/load/pkg.go
src/cmd/go/internal/modload/buildlist.go
src/cmd/internal/obj/loong64/asm.go
src/cmd/internal/obj/mips/asm0.go
src/cmd/internal/obj/s390x/asmz.go
src/cmd/link/internal/ld/pe.go

index 1836bb833c2d24a39f627b4b7e01ac6faaacd9ae..ae2e4e4ffa9975a649a0af4421679fc0d588c47c 100644 (file)
@@ -18,7 +18,7 @@ from running applications or integration tests. E.g.
 Run covdata via "go tool covdata <mode>", where 'mode' is a subcommand
 selecting a specific reporting, merging, or data manipulation operation.
 Descriptions on the various modes (run "go tool cover <mode> -help" for
-specifics on usage of a given mode:
+specifics on usage of a given mode):
 
 1. Report percent of statements covered in each profiled package
 
index 82580cd78b3cc6be96d79f82e7b7e1d6116165bd..f5b9b1c117ac1092277a80a64c903527dbb61d92 100644 (file)
@@ -11,7 +11,7 @@ annotations to track which parts of each function are executed (this
 is referred to "instrumentation"). Cover can operate in "legacy mode"
 on a single Go source file at a time, or when invoked by the Go tool
 it will process all the source files in a single package at a time
-(package-scope instrumentation is enabled via "-pkgcfg" option,
+(package-scope instrumentation is enabled via "-pkgcfg" option).
 
 When generated instrumented code, the cover tool computes approximate
 basic block information by studying the source. It is thus more
index 1801cfd824885b6b1cf855c147f6f2ed374bf0f6..1549800afb5f7e5ceee22cd4d76cb3a4ee9d7209 100644 (file)
@@ -972,7 +972,7 @@ func loadPackageData(ctx context.Context, path, parentPath, parentDir, parentRoo
                                        // accepting them.
                                        //
                                        // TODO(#41410: Figure out how this actually ought to work and fix
-                                       // this mess.
+                                       // this mess).
                                } else {
                                        data.err = r.err
                                }
index 3908e85622ed709fbe2294fc6c91c8b85c77fa7a..d72a24f111449ad60fd40780074a770826a27e23 100644 (file)
@@ -1088,7 +1088,7 @@ func updatePrunedRoots(ctx context.Context, direct map[string]bool, rs *Requirem
                        // relevant dependencies, and we explicitly don't want to pull in
                        // requirements on *irrelevant* requirements that happen to occur in the
                        // go.mod files for these transitive-test-only dependencies. (See the test
-                       // in mod_lazy_test_horizon.txt for a concrete example.
+                       // in mod_lazy_test_horizon.txt for a concrete example).
                        //
                        // The “goldilocks zone” seems to be to spot-check exactly the same
                        // modules that we promote to explicit roots: namely, those that provide
index 0ab0caafae2f3451f5617583693a27a87b224a23..19250c94ee33efc127a75fa4b0c4e8f7bcf0f04b 100644 (file)
@@ -753,7 +753,7 @@ func (c *ctxt0) aclass(a *obj.Addr) int {
                        if c.instoffset <= 0xfff {
                                return C_ANDCON
                        }
-                       if c.instoffset&0xfff == 0 && isuint32(uint64(c.instoffset)) { // && (instoffset & (1<<31)) == 0)
+                       if c.instoffset&0xfff == 0 && isuint32(uint64(c.instoffset)) { // && ((instoffset & (1<<31)) == 0)
                                return C_UCON
                        }
                        if isint32(c.instoffset) || isuint32(uint64(c.instoffset)) {
index f158b6688dc9c57f22888080b45ea515a8057354..2804073db17a8ee8b87fea300e1efefcb26a2e0b 100644 (file)
@@ -718,7 +718,7 @@ func (c *ctxt0) aclass(a *obj.Addr) int {
                        if c.instoffset <= 0xffff {
                                return C_ANDCON
                        }
-                       if c.instoffset&0xffff == 0 && isuint32(uint64(c.instoffset)) { /* && (instoffset & (1<<31)) == 0) */
+                       if c.instoffset&0xffff == 0 && isuint32(uint64(c.instoffset)) { /* && (instoffset & (1<<31)) == 0) */
                                return C_UCON
                        }
                        if isint32(c.instoffset) || isuint32(uint64(c.instoffset)) {
index 0ab492a2a54b132d2701eb168bf461fc389fe833..bf6d48e305837b30fd9443be93cc95f3be1cf1b5 100644 (file)
@@ -691,7 +691,7 @@ func (c *ctxtz) aclass(a *obj.Addr) int {
                        if c.instoffset <= 0xffff {
                                return C_ANDCON
                        }
-                       if c.instoffset&0xffff == 0 && isuint32(uint64(c.instoffset)) { /* && (instoffset & (1<<31)) == 0) */
+                       if c.instoffset&0xffff == 0 && isuint32(uint64(c.instoffset)) { /* && (instoffset & (1<<31)) == 0) */
                                return C_UCON
                        }
                        if isint32(c.instoffset) || isuint32(uint64(c.instoffset)) {
index a2c5a99e8e8773b9bd14efe4c37c603557d14c0f..7c585b327e53e218b2be729b92c62ad701a66a01 100644 (file)
@@ -777,7 +777,7 @@ func (f *peFile) writeSymbols(ctxt *Link) {
                                // so the external linker see them as Forwarder RVA exports. See:
                                //
                                //  - https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#export-address-table
-                               //  - https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=ld/pe-dll.c;h=e7b82ba6ffadf74dc1b9ee71dc13d48336941e51;hb=HEAD#l972)
+                               //  - https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=ld/pe-dll.c;h=e7b82ba6ffadf74dc1b9ee71dc13d48336941e51;hb=HEAD#l972
                                //
                                // CL 317917 changes "." to ":" in symbols name, so these symbols can not be
                                // found by external linker anymore. So a hacky way is adding the