]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go,internal/platform: enable pie buildmode for windows/arm64
authorqmuntal <quimmuntal@gmail.com>
Mon, 21 Nov 2022 12:56:19 +0000 (13:56 +0100)
committerBryan Mills <bcmills@google.com>
Mon, 21 Nov 2022 16:49:48 +0000 (16:49 +0000)
This CL adds windows/arm64 to the list of ports that supports PIE
build mode. It is probably an oversight that this port is not marked
as pie-capable because windows/arm64 only supports PIE build mode.

Fixes #56872

Change-Id: I2bdd3ac207280f47ddcf8c2582f13025dafb9278
Reviewed-on: https://go-review.googlesource.com/c/go/+/452415
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

src/cmd/go/go_test.go
src/internal/platform/supported.go

index 004edd76a47408b7635026abb905a48f5bf90cd2..d162dc8e2c022f11d4b26409c91148a227442286 100644 (file)
@@ -2136,7 +2136,7 @@ func TestBuildmodePIE(t *testing.T) {
        case "linux/386", "linux/amd64", "linux/arm", "linux/arm64", "linux/ppc64le", "linux/riscv64", "linux/s390x",
                "android/amd64", "android/arm", "android/arm64", "android/386",
                "freebsd/amd64",
-               "windows/386", "windows/amd64", "windows/arm":
+               "windows/386", "windows/amd64", "windows/arm", "windows/arm64":
        case "darwin/amd64":
        default:
                t.Skipf("skipping test because buildmode=pie is not supported on %s", platform)
index fddc5441235d9587c0db7ab02239f08318a836aa..86c9f07adedcd6a0fe9c1ad0f8593074ecc409c8 100644 (file)
@@ -129,7 +129,7 @@ func BuildModeSupported(compiler, buildmode, goos, goarch string) bool {
                        "darwin/amd64", "darwin/arm64",
                        "ios/amd64", "ios/arm64",
                        "aix/ppc64",
-                       "windows/386", "windows/amd64", "windows/arm":
+                       "windows/386", "windows/amd64", "windows/arm", "windows/arm64":
                        return true
                }
                return false