cmd: fixed certain vet warnings

Updates #11041

Change-Id: I7f2583d08f344d6622027c5e8a5de1f5d2f2881c
Reviewed-on: https://go-review.googlesource.com/23082
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

diff --git a/src/cmd/cover/cover.go b/src/cmd/cover/cover.go
index 46495950e98f53c57ae72d9ff6bbbea7a13da5cd..a9ed66eea06cd5a5eb22bbbb02c29d0df54cddfa 100644 (file)
--- a/src/cmd/cover/cover.go
+++ b/src/cmd/cover/cover.go
@@ -388,7 +388,7 @@ func trimComments(file *ast.File, fset *token.FileSet) []*ast.CommentGroup {
                        }
                }
                if list != nil {
-                       comments = append(comments, &ast.CommentGroup{list})
+                       comments = append(comments, &ast.CommentGroup{List: list})
                }
        }
        return comments

diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go
index 3d123c2c8641dad158f09598c0c6c0fbcbddd358..1a1f7d961bea77aa31b6073bacca7f5d90d4a722 100644 (file)
--- a/src/cmd/dist/test.go
+++ b/src/cmd/dist/test.go
@@ -699,7 +699,7 @@ func (t *tester) supportedBuildmode(mode string) bool {
                }
                return false
        default:
-               log.Fatal("internal error: unknown buildmode %s", mode)
+               log.Fatalf("internal error: unknown buildmode %s", mode)
                return false
        }
 }

diff --git a/src/cmd/internal/pprof/report/report.go b/src/cmd/internal/pprof/report/report.go
index c492b752b96fbb66271aaa4f644ef3500974b729..b11ad2ab3606e7333926d47a0c449bde70f505e8 100644 (file)
--- a/src/cmd/internal/pprof/report/report.go
+++ b/src/cmd/internal/pprof/report/report.go
@@ -205,7 +205,9 @@ func nodesPerSymbol(ns nodes, symbols []*objSymbol) map[*objSymbol]nodes {
 // offset to adjust the sample addresses.
 func annotateAssembly(insns []plugin.Inst, samples nodes, base uint64) nodes {
        // Add end marker to simplify printing loop.
-       insns = append(insns, plugin.Inst{^uint64(0), "", "", 0})
+       insns = append(insns, plugin.Inst{
+               Addr: ^uint64(0),
+       })
 
        // Ensure samples are sorted by address.
        samples.sort(addressOrder)

diff --git a/src/cmd/link/internal/ld/objfile.go b/src/cmd/link/internal/ld/objfile.go
index d16431ddaa29adc19baf977ad2bf638508c629d3..be9832dc45483031e7a489af5356b32fa2cae830 100644 (file)
--- a/src/cmd/link/internal/ld/objfile.go
+++ b/src/cmd/link/internal/ld/objfile.go
@@ -538,7 +538,7 @@ func (r *objReader) readSymName() string {
                origName = make([]byte, n)
                r.readFull(origName)
        } else if err != nil {
-               log.Fatalf("%s: error reading symbol: %v", err)
+               log.Fatalf("%s: error reading symbol: %v", r.pn, err)
        }
        adjName := r.rdBuf[:0]
        for {