]> Cypherpunks repositories - gostls13.git/commitdiff
path/filepath: better error reporting during TestWinSplitListTestsAreValid
authorAlex Brainman <alex.brainman@gmail.com>
Fri, 1 Mar 2013 03:49:55 +0000 (14:49 +1100)
committerAlex Brainman <alex.brainman@gmail.com>
Fri, 1 Mar 2013 03:49:55 +0000 (14:49 +1100)
Fixes #4930.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/7424043

src/pkg/path/filepath/path_windows_test.go

index 8f8e82ae50b0acdfa5c8f3277a62c4724b48a8ac..d8926adde55adea685631cb0e9f1a6aba59e8502 100644 (file)
@@ -70,10 +70,10 @@ func testWinSplitListTestIsValid(t *testing.T, ti int, tt SplitListTest,
                        Env:  []string{`Path=` + tt.list},
                        Dir:  tmp,
                }
-               out, err := cmd.Output()
+               out, err := cmd.CombinedOutput()
                switch {
                case err != nil:
-                       t.Errorf("%d,%d: execution error %v", ti, i, err)
+                       t.Errorf("%d,%d: execution error %v\n%q", ti, i, err, out)
                        return
                case !reflect.DeepEqual(out, exp):
                        t.Errorf("%d,%d: expected %#q, got %#q", ti, i, exp, out)