cmd/internal/gc: make Node.Needzero a bool

Node.Needzero only has two values and acts as a bool, so make it a bool.

Change-Id: Ica46e5ebafbe478017ea52ce6bb335f404059677
Reviewed-on: https://go-review.googlesource.com/6800
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Dave Cheney <dave@cheney.net>
TryBot-Result: Gobot Gobot <gobot@golang.org>

diff --git a/src/cmd/5g/ggen.go b/src/cmd/5g/ggen.go
index cb8485dba53f6761593cd6c8cb2dec853d25a585..3ee9405b88d01e9ca6c77f804ce05ccc1d1b3e6e 100644 (file)
--- a/src/cmd/5g/ggen.go
+++ b/src/cmd/5g/ggen.go
@@ -30,7 +30,7 @@ func defframe(ptxt *obj.Prog) {
        r0 := uint32(0)
        for l := gc.Curfn.Dcl; l != nil; l = l.Next {
                n = l.N
-               if n.Needzero == 0 {
+               if !n.Needzero {
                        continue
                }
                if n.Class != gc.PAUTO {

diff --git a/src/cmd/6g/ggen.go b/src/cmd/6g/ggen.go
index 3e74ce3757f08570b5e0b9818a48a4f7e7827b52..efbbded1d3c64ebb07c69d5b37bd5876f0846f3e 100644 (file)
--- a/src/cmd/6g/ggen.go
+++ b/src/cmd/6g/ggen.go
@@ -32,7 +32,7 @@ func defframe(ptxt *obj.Prog) {
        // iterate through declarations - they are sorted in decreasing xoffset order.
        for l := gc.Curfn.Dcl; l != nil; l = l.Next {
                n = l.N
-               if n.Needzero == 0 {
+               if !n.Needzero {
                        continue
                }
                if n.Class != gc.PAUTO {

diff --git a/src/cmd/8g/ggen.go b/src/cmd/8g/ggen.go
index eb5eae2bba913537cd0ae37cd6cf4911c9e63b7e..550ded9d3f38b1ffc5a253e39361396d9b31d98c 100644 (file)
--- a/src/cmd/8g/ggen.go
+++ b/src/cmd/8g/ggen.go
@@ -30,7 +30,7 @@ func defframe(ptxt *obj.Prog) {
        ax := uint32(0)
        for l := gc.Curfn.Dcl; l != nil; l = l.Next {
                n = l.N
-               if n.Needzero == 0 {
+               if !n.Needzero {
                        continue
                }
                if n.Class != gc.PAUTO {

diff --git a/src/cmd/9g/ggen.go b/src/cmd/9g/ggen.go
index 3cca4a57512f487ec55c6e3238c11329bd599758..6bf1d5637364fbcf63f61b8010c6b0cb1ef7edd4 100644 (file)
--- a/src/cmd/9g/ggen.go
+++ b/src/cmd/9g/ggen.go
@@ -32,7 +32,7 @@ func defframe(ptxt *obj.Prog) {
        // iterate through declarations - they are sorted in decreasing xoffset order.
        for l := gc.Curfn.Dcl; l != nil; l = l.Next {
                n = l.N
-               if n.Needzero == 0 {
+               if !n.Needzero {
                        continue
                }
                if n.Class != gc.PAUTO {

diff --git a/src/cmd/internal/gc/go.go b/src/cmd/internal/gc/go.go
index 2d460f75c055e9482f15fba8bf61d8068b9c786d..bab33736801a9edcba5d6e91ec41ba21bf5f7b7f 100644 (file)
--- a/src/cmd/internal/gc/go.go
+++ b/src/cmd/internal/gc/go.go
@@ -174,7 +174,7 @@ type Node struct {
        Reslice        uint8
        Likely         int8
        Hasbreak       uint8
-       Needzero       uint8
+       Needzero       bool
        Needctxt       bool
        Esc            uint
        Funcdepth      int

diff --git a/src/cmd/internal/gc/pgen.go b/src/cmd/internal/gc/pgen.go
index 1f3fa017479fd4c9cfe81344c970345dd0f64d38..e78a0d03262caccd481c0a8cbcfc668f05be6dc0 100644 (file)
--- a/src/cmd/internal/gc/pgen.go
+++ b/src/cmd/internal/gc/pgen.go
@@ -211,8 +211,8 @@ func cmpstackvar(a *Node, b *Node) int {
                return bp - ap
        }
 
-       ap = int(a.Needzero)
-       bp = int(b.Needzero)
+       ap = bool2int(a.Needzero)
+       bp = bool2int(b.Needzero)
        if ap != bp {
                return bp - ap
        }

diff --git a/src/cmd/internal/gc/plive.go b/src/cmd/internal/gc/plive.go
index 229489f0254dbce884a5415b7bf58708e812999a..100b82be066635302a478c64dfff09683f263f80 100644 (file)
--- a/src/cmd/internal/gc/plive.go
+++ b/src/cmd/internal/gc/plive.go
@@ -1255,8 +1255,8 @@ func livenessepilogue(lv *Liveness) {
                                                }
                                                bvset(all, pos) // silence future warnings in this block
                                                n = lv.vars[pos]
-                                               if n.Needzero == 0 {
-                                                       n.Needzero = 1
+                                               if !n.Needzero {
+                                                       n.Needzero = true
                                                        if debuglive >= 1 {
                                                                Warnl(int(p.Lineno), "%v: %v is ambiguously live", Nconv(Curfn.Nname, 0), Nconv(n, obj.FmtLong))
                                                        }