]> Cypherpunks repositories - gostls13.git/commitdiff
net: panic if sockaddrToTCP returns nil incorrectly
authorRob Pike <r@golang.org>
Tue, 21 Feb 2012 04:21:34 +0000 (15:21 +1100)
committerRob Pike <r@golang.org>
Tue, 21 Feb 2012 04:21:34 +0000 (15:21 +1100)
Part of diagnosing the selfConnect bug
TBR=dsymonds

R=golang-dev
CC=golang-dev
https://golang.org/cl/5687057

src/pkg/net/tcpsock_posix.go

index 28d170730805a30e3d76cf1f3319b71ca6accf16..1280f7bb08b9338a45faa91cebc23d6fa0c49141 100644 (file)
@@ -9,6 +9,7 @@
 package net
 
 import (
+       "fmt"
        "io"
        "os"
        "syscall"
@@ -26,6 +27,12 @@ func sockaddrToTCP(sa syscall.Sockaddr) Addr {
                return &TCPAddr{sa.Addr[0:], sa.Port}
        case *syscall.SockaddrInet6:
                return &TCPAddr{sa.Addr[0:], sa.Port}
+       default:
+               if sa != nil {
+                       // TODO(r): Diagnose when we will turn a non-nil sockaddr into a nil.
+                       // Part of diagnosing the selfConnect bug.
+                       panic(fmt.Sprintf("unexpected type in sockaddrToTCP: %T", sa))
+               }
        }
        return nil
 }