go/internal/gcimport: unskip Windows tests

There are many tests in internal/gcimporter that are skipped on
Windows because they build a test program that needs the -D flag
when invoking the Go compiler.

This flag is already passed since CL 442303, so there is no need to
skip those tests.

Change-Id: I877e670194048bda9a52ad2568650cf33eacfb5a
Reviewed-on: https://go-review.googlesource.com/c/go/+/480415
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>

diff --git a/src/cmd/compile/internal/importer/gcimporter_test.go b/src/cmd/compile/internal/importer/gcimporter_test.go
index 26e43e6ba4a8200e16c04f918ae36135f28fa733..96c5f69e64bb5b627a8f53e30bf26f548a39efd8 100644 (file)
--- a/src/cmd/compile/internal/importer/gcimporter_test.go
+++ b/src/cmd/compile/internal/importer/gcimporter_test.go
@@ -426,12 +426,6 @@ func TestIssue13566(t *testing.T) {
                t.Skipf("gc-built packages not available (compiler = %s)", runtime.Compiler)
        }
 
-       // On windows, we have to set the -D option for the compiler to avoid having a drive
-       // letter and an illegal ':' in the import path - just skip it (see also issue #3483).
-       if runtime.GOOS == "windows" {
-               t.Skip("avoid dealing with relative paths/drive letters on windows")
-       }
-
        tmpdir := mktmpdir(t)
        testoutdir := filepath.Join(tmpdir, "testdata")
 
@@ -516,12 +510,6 @@ func TestIssue15517(t *testing.T) {
                t.Skipf("gc-built packages not available (compiler = %s)", runtime.Compiler)
        }
 
-       // On windows, we have to set the -D option for the compiler to avoid having a drive
-       // letter and an illegal ':' in the import path - just skip it (see also issue #3483).
-       if runtime.GOOS == "windows" {
-               t.Skip("avoid dealing with relative paths/drive letters on windows")
-       }
-
        tmpdir := mktmpdir(t)
 
        compile(t, "testdata", "p.go", filepath.Join(tmpdir, "testdata"), nil)
@@ -554,12 +542,6 @@ func TestIssue15920(t *testing.T) {
                t.Skipf("gc-built packages not available (compiler = %s)", runtime.Compiler)
        }
 
-       // On windows, we have to set the -D option for the compiler to avoid having a drive
-       // letter and an illegal ':' in the import path - just skip it (see also issue #3483).
-       if runtime.GOOS == "windows" {
-               t.Skip("avoid dealing with relative paths/drive letters on windows")
-       }
-
        compileAndImportPkg(t, "issue15920")
 }
 
@@ -571,12 +553,6 @@ func TestIssue20046(t *testing.T) {
                t.Skipf("gc-built packages not available (compiler = %s)", runtime.Compiler)
        }
 
-       // On windows, we have to set the -D option for the compiler to avoid having a drive
-       // letter and an illegal ':' in the import path - just skip it (see also issue #3483).
-       if runtime.GOOS == "windows" {
-               t.Skip("avoid dealing with relative paths/drive letters on windows")
-       }
-
        // "./issue20046".V.M must exist
        pkg := compileAndImportPkg(t, "issue20046")
        obj := lookupObj(t, pkg.Scope(), "V")
@@ -592,12 +568,6 @@ func TestIssue25301(t *testing.T) {
                t.Skipf("gc-built packages not available (compiler = %s)", runtime.Compiler)
        }
 
-       // On windows, we have to set the -D option for the compiler to avoid having a drive
-       // letter and an illegal ':' in the import path - just skip it (see also issue #3483).
-       if runtime.GOOS == "windows" {
-               t.Skip("avoid dealing with relative paths/drive letters on windows")
-       }
-
        compileAndImportPkg(t, "issue25301")
 }
 
@@ -609,12 +579,6 @@ func TestIssue25596(t *testing.T) {
                t.Skipf("gc-built packages not available (compiler = %s)", runtime.Compiler)
        }
 
-       // On windows, we have to set the -D option for the compiler to avoid having a drive
-       // letter and an illegal ':' in the import path - just skip it (see also issue #3483).
-       if runtime.GOOS == "windows" {
-               t.Skip("avoid dealing with relative paths/drive letters on windows")
-       }
-
        compileAndImportPkg(t, "issue25596")
 }
 

diff --git a/src/go/internal/gcimporter/gcimporter_test.go b/src/go/internal/gcimporter/gcimporter_test.go
index 800c372971acc3441f23a5a3492891be63888596..9ab29f3b1cb6d4ad24c78a0f506d4be2d3d8c769 100644 (file)
--- a/src/go/internal/gcimporter/gcimporter_test.go
+++ b/src/go/internal/gcimporter/gcimporter_test.go
@@ -530,12 +530,6 @@ func TestIssue13566(t *testing.T) {
                t.Skipf("gc-built packages not available (compiler = %s)", runtime.Compiler)
        }
 
-       // On windows, we have to set the -D option for the compiler to avoid having a drive
-       // letter and an illegal ':' in the import path - just skip it (see also issue #3483).
-       if runtime.GOOS == "windows" {
-               t.Skip("avoid dealing with relative paths/drive letters on windows")
-       }
-
        tmpdir := mktmpdir(t)
        defer os.RemoveAll(tmpdir)
        testoutdir := filepath.Join(tmpdir, "testdata")
@@ -570,12 +564,6 @@ func TestTypeNamingOrder(t *testing.T) {
                t.Skipf("gc-built packages not available (compiler = %s)", runtime.Compiler)
        }
 
-       // On windows, we have to set the -D option for the compiler to avoid having a drive
-       // letter and an illegal ':' in the import path - just skip it (see also issue #3483).
-       if runtime.GOOS == "windows" {
-               t.Skip("avoid dealing with relative paths/drive letters on windows")
-       }
-
        tmpdir := mktmpdir(t)
        defer os.RemoveAll(tmpdir)
        testoutdir := filepath.Join(tmpdir, "testdata")
@@ -641,12 +629,6 @@ func TestIssue15517(t *testing.T) {
                t.Skipf("gc-built packages not available (compiler = %s)", runtime.Compiler)
        }
 
-       // On windows, we have to set the -D option for the compiler to avoid having a drive
-       // letter and an illegal ':' in the import path - just skip it (see also issue #3483).
-       if runtime.GOOS == "windows" {
-               t.Skip("avoid dealing with relative paths/drive letters on windows")
-       }
-
        tmpdir := mktmpdir(t)
        defer os.RemoveAll(tmpdir)
 
@@ -681,12 +663,6 @@ func TestIssue15920(t *testing.T) {
                t.Skipf("gc-built packages not available (compiler = %s)", runtime.Compiler)
        }
 
-       // On windows, we have to set the -D option for the compiler to avoid having a drive
-       // letter and an illegal ':' in the import path - just skip it (see also issue #3483).
-       if runtime.GOOS == "windows" {
-               t.Skip("avoid dealing with relative paths/drive letters on windows")
-       }
-
        compileAndImportPkg(t, "issue15920")
 }
 
@@ -698,12 +674,6 @@ func TestIssue20046(t *testing.T) {
                t.Skipf("gc-built packages not available (compiler = %s)", runtime.Compiler)
        }
 
-       // On windows, we have to set the -D option for the compiler to avoid having a drive
-       // letter and an illegal ':' in the import path - just skip it (see also issue #3483).
-       if runtime.GOOS == "windows" {
-               t.Skip("avoid dealing with relative paths/drive letters on windows")
-       }
-
        // "./issue20046".V.M must exist
        pkg := compileAndImportPkg(t, "issue20046")
        obj := lookupObj(t, pkg.Scope(), "V")
@@ -719,12 +689,6 @@ func TestIssue25301(t *testing.T) {
                t.Skipf("gc-built packages not available (compiler = %s)", runtime.Compiler)
        }
 
-       // On windows, we have to set the -D option for the compiler to avoid having a drive
-       // letter and an illegal ':' in the import path - just skip it (see also issue #3483).
-       if runtime.GOOS == "windows" {
-               t.Skip("avoid dealing with relative paths/drive letters on windows")
-       }
-
        compileAndImportPkg(t, "issue25301")
 }
 
@@ -736,12 +700,6 @@ func TestIssue25596(t *testing.T) {
                t.Skipf("gc-built packages not available (compiler = %s)", runtime.Compiler)
        }
 
-       // On windows, we have to set the -D option for the compiler to avoid having a drive
-       // letter and an illegal ':' in the import path - just skip it (see also issue #3483).
-       if runtime.GOOS == "windows" {
-               t.Skip("avoid dealing with relative paths/drive letters on windows")
-       }
-
        compileAndImportPkg(t, "issue25596")
 }
 
@@ -753,12 +711,6 @@ func TestIssue57015(t *testing.T) {
                t.Skipf("gc-built packages not available (compiler = %s)", runtime.Compiler)
        }
 
-       // On windows, we have to set the -D option for the compiler to avoid having a drive
-       // letter and an illegal ':' in the import path - just skip it (see also issue #3483).
-       if runtime.GOOS == "windows" {
-               t.Skip("avoid dealing with relative paths/drive letters on windows")
-       }
-
        compileAndImportPkg(t, "issue57015")
 }