]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: temporarily disable build JSON in test output
authorAustin Clements <austin@google.com>
Mon, 18 Nov 2024 03:41:03 +0000 (22:41 -0500)
committerCherry Mui <cherryyz@google.com>
Mon, 18 Nov 2024 04:56:52 +0000 (04:56 +0000)
Unfortunately, this is tripping up the LUCI test output processor, so
we need to disable it until we can figure that out.

For #70402.
Updates #62067.

Cq-Include-Trybots: luci.golang.try:gotip-darwin-arm64_13,gotip-linux-amd64-longtest
Change-Id: I9ae722218e98b8060b8b4c46358f23381ac8537a
Reviewed-on: https://go-review.googlesource.com/c/go/+/628955
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/cmd/go/internal/test/testflag.go
src/cmd/go/testdata/script/test_json_build.txt

index 30da2b08c1c8131f15964822294b61e670a8b9a5..f91e4e6705b3a0d9747301642d18d897c3ccd036 100644 (file)
@@ -6,7 +6,6 @@ package test
 
 import (
        "cmd/go/internal/base"
-       "cmd/go/internal/cfg"
        "cmd/go/internal/cmdflag"
        "cmd/go/internal/work"
        "errors"
@@ -355,7 +354,8 @@ func testFlags(args []string) (packageNames, passToTest []string) {
                delete(addFromGOFLAGS, "v")
                delete(addFromGOFLAGS, "test.v")
 
-               cfg.BuildJSON = true
+               // TODO(austin,#70402): Re-enable this once LUCI can handle build JSON in the test stream.
+               //cfg.BuildJSON = true
        }
 
        // Inject flags from GOFLAGS before the explicit command-line arguments.
index f3e08d035fb813a7d2c23f64a804b6e9e0695057..d3d0c8bb1ea5c9d5080502ae6b004546d7afb1dd 100644 (file)
@@ -1,3 +1,6 @@
+# TODO(austin,#70402)
+skip
+
 [short] skip
 
 # Test a build error directly in a test file.