]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/asm: remove pointless check for negative uint
authorRob Pike <r@golang.org>
Sat, 20 Jun 2015 23:10:39 +0000 (09:10 +1000)
committerRob Pike <r@golang.org>
Sun, 21 Jun 2015 03:11:01 +0000 (03:11 +0000)
Fixes #11278.

Change-Id: Ic46fda0f42cefedc3f6085c0e77e67616ce4955e
Reviewed-on: https://go-review.googlesource.com/11297
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/asm/internal/asm/parse.go

index 72e91b8e55aeb02d5acadf7b5e5156b1a6d7bee4..7f956cb2a8b02f4a6e72e8b1f6bbc27027eb268b 100644 (file)
@@ -807,9 +807,7 @@ func (p *Parser) term() uint64 {
                case lex.LSH:
                        p.next()
                        shift := p.factor()
-                       if int64(shift) < 0 {
-                               p.errorf("negative left shift %d", shift)
-                       }
+                       // shift is a uint, so can never be negative.
                        return value << shift
                case lex.RSH:
                        p.next()