]> Cypherpunks repositories - gostls13.git/commitdiff
exp/inotify: fix data race in linux tests
authorDmitriy Vyukov <dvyukov@google.com>
Mon, 16 Jan 2012 07:11:58 +0000 (11:11 +0400)
committerDmitriy Vyukov <dvyukov@google.com>
Mon, 16 Jan 2012 07:11:58 +0000 (11:11 +0400)
Fixes #2708.

R=golang-dev, bradfitz
CC=golang-dev, mpimenov
https://golang.org/cl/5543060

src/pkg/exp/inotify/inotify_linux_test.go

index d035ec1410ff16afd9daa9a349e29de06ff5c18b..c2160fc65375d42198940fa55d9285848c3b435f 100644 (file)
@@ -83,14 +83,15 @@ func TestInotifyClose(t *testing.T) {
        watcher, _ := NewWatcher()
        watcher.Close()
 
-       done := false
+       done := make(chan bool)
        go func() {
                watcher.Close()
-               done = true
+               done <- true
        }()
 
-       time.Sleep(50 * time.Millisecond)
-       if !done {
+       select {
+       case <-done:
+       case <-time.After(50 * time.Millisecond):
                t.Fatal("double Close() test failed: second Close() call didn't return")
        }