]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.24] debug/pe: permit symbols with no name
authorIan Lance Taylor <iant@golang.org>
Mon, 1 Sep 2025 16:18:08 +0000 (09:18 -0700)
committerCarlos Amedee <carlos@golang.org>
Wed, 1 Oct 2025 18:58:07 +0000 (11:58 -0700)
They are reportedly generated by llvm-mingw clang21.

For #75219
Fixes #75220

Change-Id: I7fa7e13039bc7eee826cc19826985ca0e357a9ff
Reviewed-on: https://go-review.googlesource.com/c/go/+/700137
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit ea00650784bc2909580c7decf729f668349aa939)
Reviewed-on: https://go-review.googlesource.com/c/go/+/708357

src/debug/pe/symbol.go

index 6e8d9d16c2254015fd6a7b9bc2a68788327f69c6..80acebe9f1f40b9fbe9d8255b7d07cb924a2a540 100644 (file)
@@ -98,7 +98,12 @@ func readCOFFSymbols(fh *FileHeader, r io.ReadSeeker) ([]COFFSymbol, error) {
 // isSymNameOffset checks symbol name if it is encoded as offset into string table.
 func isSymNameOffset(name [8]byte) (bool, uint32) {
        if name[0] == 0 && name[1] == 0 && name[2] == 0 && name[3] == 0 {
-               return true, binary.LittleEndian.Uint32(name[4:])
+               offset := binary.LittleEndian.Uint32(name[4:])
+               if offset == 0 {
+                       // symbol has no name
+                       return false, 0
+               }
+               return true, offset
        }
        return false, 0
 }