]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: cleanup atomic.Pointer[T] inline test
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Tue, 31 Jan 2023 19:04:29 +0000 (02:04 +0700)
committerGopher Robot <gobot@golang.org>
Tue, 31 Jan 2023 20:36:13 +0000 (20:36 +0000)
Updates #57410

Change-Id: I9be38e20c6b83d14f7785049a66de77ac7ecdf15
Reviewed-on: https://go-review.googlesource.com/c/go/+/463997
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/test/inl_test.go

index eacbe62e68747f79bf175f1c6667839ce8b8ae19..3dda480d36baddd3ef28a952a5ef6bbe5ab6a967 100644 (file)
@@ -208,7 +208,10 @@ func TestIntendedInlining(t *testing.T) {
                        "(*Uintptr).Load",
                        "(*Uintptr).Store",
                        "(*Uintptr).Swap",
-                       // (*Pointer[T])'s methods' handled below.
+                       "(*Pointer[go.shape.int]).CompareAndSwap",
+                       "(*Pointer[go.shape.int]).Load",
+                       "(*Pointer[go.shape.int]).Store",
+                       "(*Pointer[go.shape.int]).Swap",
                },
        }
 
@@ -234,14 +237,6 @@ func TestIntendedInlining(t *testing.T) {
                // (*Bool).CompareAndSwap is just over budget on 32-bit systems (386, arm).
                want["sync/atomic"] = append(want["sync/atomic"], "(*Bool).CompareAndSwap")
        }
-       if true /* was buildcfg.Experiment.Unified */ {
-               // Non-unified IR does not report "inlining call ..." for atomic.Pointer[T]'s methods.
-               // TODO(cuonglm): remove once non-unified IR frontend gone.
-               want["sync/atomic"] = append(want["sync/atomic"], "(*Pointer[go.shape.int]).CompareAndSwap")
-               want["sync/atomic"] = append(want["sync/atomic"], "(*Pointer[go.shape.int]).Load")
-               want["sync/atomic"] = append(want["sync/atomic"], "(*Pointer[go.shape.int]).Store")
-               want["sync/atomic"] = append(want["sync/atomic"], "(*Pointer[go.shape.int]).Swap")
-       }
 
        switch runtime.GOARCH {
        case "386", "wasm", "arm":