]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist: really skip the testsanitizers tests on Android
authorElias Naur <elias.naur@gmail.com>
Mon, 30 Jan 2017 18:55:35 +0000 (19:55 +0100)
committerElias Naur <elias.naur@gmail.com>
Mon, 30 Jan 2017 20:38:03 +0000 (20:38 +0000)
The test.bash script in misc/cgo/testsanitizers use GOOS, not GOHOSTOS.
Fix the dist check from gohostos to goos accordingly.

The error was masked on the builders because they run on a darwin host
where the sanitizers tests never ran.

With this change, the Android test suite completes successfully on
Android/amd64.

Change-Id: Id7690429f78c6ac7a26fc9118d913b719b565bb2
Reviewed-on: https://go-review.googlesource.com/35959
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Elias Naur <elias.naur@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/dist/test.go

index 8ad4a8620da0b04334bb3cacd16f1ad395b60b63..c51dcead2b3fd8d47d00a71490145cb61ba7026b 100644 (file)
@@ -567,7 +567,7 @@ func (t *tester) registerTests() {
                if t.gohostos == "linux" && t.goarch == "amd64" {
                        t.registerTest("testasan", "../misc/cgo/testasan", "go", "run", "main.go")
                }
-               if t.gohostos == "linux" && t.goarch == "amd64" {
+               if t.goos == "linux" && t.goarch == "amd64" {
                        t.registerTest("testsanitizers", "../misc/cgo/testsanitizers", "./test.bash")
                }
                if t.hasBash() && t.goos != "android" && !t.iOS() && t.gohostos != "windows" {