]> Cypherpunks repositories - gostls13.git/commitdiff
net/http/httputil: remove os.Stderr claim in ReverseProxy.ErrorLog docs
authorDmitri Shuralyov <dmitshur@golang.org>
Sun, 12 May 2019 23:21:33 +0000 (19:21 -0400)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 17 May 2019 17:33:16 +0000 (17:33 +0000)
The motivation for doing so is to avoid making inaccurate claims.
Logging may not go to os.Stderr if anyone overrides the log package's
default output via https://godoc.org/log#SetOutput. Saying that
the standard logger is used should be sufficient to explain the
behavior, and users can infer that os.Stderr is used by default,
unless it's changed.

This change is the same as what was applied to http.Server.ErrorLog
documentation in CL 53950.

Change-Id: I32873fc548ceee573f8616b4d49b8a8b98881803
Reviewed-on: https://go-review.googlesource.com/c/go/+/176817
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/httputil/reverseproxy.go

index 7bb469e5c3efbabdd4bce3dab896aaaf4c4c4695..1d7b0efa11b91ff7cc463497dc3270c33534569e 100644 (file)
@@ -51,8 +51,7 @@ type ReverseProxy struct {
 
        // ErrorLog specifies an optional logger for errors
        // that occur when attempting to proxy the request.
-       // If nil, logging goes to os.Stderr via the log package's
-       // standard logger.
+       // If nil, logging is done via the log package's standard logger.
        ErrorLog *log.Logger
 
        // BufferPool optionally specifies a buffer pool to