]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: simplify code, reduce allocations.
authorDmitri Shuralyov <shurcooL@gmail.com>
Sun, 11 May 2014 01:06:58 +0000 (18:06 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Sun, 11 May 2014 01:06:58 +0000 (18:06 -0700)
This is a trivial change to make use of an existing `nl` byte slice
containing a single '\n' character. It's already declared and
used in another place in this file, so it might as well be used
in the other location instead of
a new slice literal. There should be no change in behavior,
aside from potentially less allocations.

This is my first CL, so I wanted to use a simple, hopefully non-controversial,
minor improvement to get more comfortable with golang contribution process.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/97280043

src/cmd/go/list.go

index 63cd4f4f6fe8de8e54ba232c944377597539da1e..0ead4350238231d8b41fc3be12ce9fcae1abaea3 100644 (file)
@@ -161,7 +161,7 @@ func runList(cmd *Command, args []string) {
                                fatalf("%s", err)
                        }
                        if out.NeedNL() {
-                               out.Write([]byte{'\n'})
+                               out.Write(nl)
                        }
                }
        }