]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/link: require cgo internal linking in TestIssue33979
authorMichael Pratt <mpratt@google.com>
Wed, 21 May 2025 14:58:32 +0000 (10:58 -0400)
committerGopher Robot <gobot@golang.org>
Wed, 21 May 2025 17:42:43 +0000 (10:42 -0700)
This was a typo regression in CL 643897, which accidentally dropped the
requirement for cgo internal linking. As a result, this test is
continuously failing on windows-arm64.

For #71395.

Cq-Include-Trybots: luci.golang.try:gotip-windows-arm64
Change-Id: I6a6a636c25fd399cda6649ef94655aa112f10f63
Reviewed-on: https://go-review.googlesource.com/c/go/+/675015
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

src/cmd/link/link_test.go

index f26495a2b1f02e6961f0d3c0830ee69995b4cb77..c3614c73f073c5d1113975e7bbfa84243f05cd13 100644 (file)
@@ -195,7 +195,7 @@ func TestIssue33979(t *testing.T) {
        testenv.MustHaveCGO(t)
        // N.B. go build below explictly doesn't pass through
        // -asan/-msan/-race, so we don't care about those.
-       testenv.MustInternalLink(t, testenv.NoSpecialBuildTypes)
+       testenv.MustInternalLink(t, testenv.SpecialBuildTypes{Cgo: true})
 
        t.Parallel()