]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: fix heap dump test on android
authorKeith Randall <khr@golang.org>
Tue, 7 Jun 2016 16:54:09 +0000 (09:54 -0700)
committerKeith Randall <khr@golang.org>
Tue, 7 Jun 2016 17:34:48 +0000 (17:34 +0000)
go_android_exec is looking for "exitcode=" to decide the result
of running a test.  The heap dump test nondeterministically prints
"finalized" right at the end of the test.  When the timing is just
right, we print "finalizedexitcode=0" and confuse go_android_exec.

This failure happens occasionally on the android builders.

Change-Id: I4f73a4db05d8f40047ecd3ef3a881a4ae3741e26
Reviewed-on: https://go-review.googlesource.com/23861
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
src/runtime/debug/heapdump_test.go

index 5761c015b8e28676565aabdd805b3eb722ba432f..7d5b950895d5316cc490a899138b87f175f7e4cc 100644 (file)
@@ -38,7 +38,7 @@ type Obj struct {
 }
 
 func objfin(x *Obj) {
-       println("finalized", x)
+       //println("finalized", x)
 }
 
 func TestWriteHeapDumpFinalizers(t *testing.T) {