[dev.regabi] cmd/compile: comment out //go:linkname warning

It's noisy and not doing any harm, and we still have an entire release
cycle to revisit and address the issue properly.

Updates #42938

Change-Id: I1de5cfb495a8148c9c08b215deba38f2617fb467
Reviewed-on: https://go-review.googlesource.com/c/go/+/274732
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>

diff --git a/src/cmd/compile/internal/gc/noder.go b/src/cmd/compile/internal/gc/noder.go
index de7dcda15eaeb0296fdfbcdecac41defe20d97a0..e5677f921fc80f865d48db4f6e8af64f1c483fff 100644 (file)
--- a/src/cmd/compile/internal/gc/noder.go
+++ b/src/cmd/compile/internal/gc/noder.go
@@ -275,7 +275,7 @@ func (p *noder) processPragmas() {
                n := ir.AsNode(lookup(l.local).Def)
                if n == nil || n.Op() != ir.ONAME {
                        // TODO(mdempsky): Change to p.errorAt before Go 1.17 release.
-                       base.WarnfAt(p.makeXPos(l.pos), "//go:linkname must refer to declared function or variable (will be an error in Go 1.17)")
+                       // base.WarnfAt(p.makeXPos(l.pos), "//go:linkname must refer to declared function or variable (will be an error in Go 1.17)")
                        continue
                }
                if n.Sym().Linkname != "" {

diff --git a/test/linkname2.go b/test/linkname2.go
index cb7f9be3452a04a247391c5fc6c54a1b4e68f183..43e66a584958bbb03fd2177b01b20f87c62c6871 100644 (file)
--- a/test/linkname2.go
+++ b/test/linkname2.go
@@ -16,10 +16,13 @@ var x, y int
 //go:linkname x ok
 
 // ERROR "//go:linkname requires linkname argument or -p compiler flag"
-// ERROR "//go:linkname must refer to declared function or variable"
-// ERROR "//go:linkname must refer to declared function or variable"
+// BAD: want error "//go:linkname must refer to declared function or variable"
+// BAD: want error "//go:linkname must refer to declared function or variable"
 // ERROR "duplicate //go:linkname for x"
 
+// The two BAD lines are just waiting for #42938 before we can
+// re-enable the errors.
+
 //line linkname2.go:18
 //go:linkname y
 //go:linkname nonexist nonexist