]> Cypherpunks repositories - gostls13.git/commitdiff
[dev.fuzz] testing: fix internal error exit condition for fuzz workers
authorJay Conrod <jayconrod@google.com>
Tue, 14 Sep 2021 22:09:06 +0000 (15:09 -0700)
committerJay Conrod <jayconrod@google.com>
Wed, 15 Sep 2021 20:08:50 +0000 (20:08 +0000)
A fuzz worker process should exit with fuzzWorkerExitCode (70) if it
encounters an internal error.

This should generally only happen due to an I/O error on the worker
side. I can't think of a way to write a realistic test case for
this. test_fuzz_io_error.txt triggers an I/O error on the coordinator
side, which is similar.

Change-Id: I40d2e9aaf422e5ed925debcf7a152c252c3a6984
Reviewed-on: https://go-review.googlesource.com/c/go/+/349993
Trust: Jay Conrod <jayconrod@google.com>
Trust: Katie Hockman <katie@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
src/testing/testing.go

index f4d2b26650b51ea32d4daa7fee305d6d409f8d0c..18a0657561cff12e690878f90432643e83c3a675 100644 (file)
@@ -1635,7 +1635,7 @@ func (m *M) Run() (code int) {
        }
 
        fuzzingOk := runFuzzing(m.deps, m.fuzzTargets)
-       if !*isFuzzWorker && !fuzzingOk {
+       if !fuzzingOk {
                fmt.Println("FAIL")
                if *isFuzzWorker {
                        m.exitCode = fuzzWorkerExitCode