]> Cypherpunks repositories - gostls13.git/commitdiff
net/http/pprof: skip TestDeltaProfile on all arm and arm64 architectures
authorBryan C. Mills <bcmills@google.com>
Tue, 8 Feb 2022 20:24:33 +0000 (15:24 -0500)
committerBryan Mills <bcmills@google.com>
Tue, 8 Mar 2022 22:10:32 +0000 (22:10 +0000)
Given that we have seen failures with the same failure mode on both
openbsd/arm and android/arm64, it seems likely that the underlying bug
affects at least all ARM-based architectures.

It appears that either these architectures are not able to sample at
the frequency expected by the test, or the samples are for some reason
being dropped.

For #50218

Change-Id: I42a6c8ecda57448f8068e8facb42a4a2cecbbb37
Reviewed-on: https://go-review.googlesource.com/c/go/+/383997
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/net/http/pprof/pprof_test.go

index 1a4d653a62d26bb812c92ef704c6480f403ba416..f82ad45bf6fecc36a5907e3df701b7bc61fc079b 100644 (file)
@@ -153,7 +153,7 @@ func mutexHog(duration time.Duration, hogger func(mu1, mu2 *sync.Mutex, start ti
 }
 
 func TestDeltaProfile(t *testing.T) {
-       if runtime.GOOS == "openbsd" && runtime.GOARCH == "arm" {
+       if strings.HasPrefix(runtime.GOARCH, "arm") {
                testenv.SkipFlaky(t, 50218)
        }