]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: add missing unlock in sysReserveAlignedSbrk
authorCherry Mui <cherryyz@google.com>
Sun, 22 Jun 2025 19:01:27 +0000 (15:01 -0400)
committerCherry Mui <cherryyz@google.com>
Mon, 23 Jun 2025 19:03:10 +0000 (12:03 -0700)
sysReserveAlignedSbrk locks memlock at entry, but it is not
unlocked at one of the return path. Add the missing unlock.

Fixes #74339.

Change-Id: Ib641bc348aca41494ec410e2c4eb9857f3362484
Reviewed-on: https://go-review.googlesource.com/c/go/+/683295
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/runtime/mem_sbrk.go

index 9d6842ae52c3a6a0a4bc63f2df8890e2adaa5db9..05f0fdb5d74ed6d58ff39af0d0f5ed6c3714273d 100644 (file)
@@ -231,6 +231,7 @@ func sysReserveAlignedSbrk(size, align uintptr) (unsafe.Pointer, uintptr) {
                        memFree(unsafe.Pointer(end), endLen)
                }
                memCheck()
+               unlock(&memlock)
                return unsafe.Pointer(pAligned), size
        }