]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/link: adjust whitelist for -strictdups checking for plan9
authorThan McIntosh <thanm@google.com>
Fri, 19 Apr 2019 18:50:57 +0000 (14:50 -0400)
committerThan McIntosh <thanm@google.com>
Fri, 19 Apr 2019 19:47:04 +0000 (19:47 +0000)
Add a couple of additional entries to the white list used to screen
out errors for builtin functions; these correspond to cases
that appear to come up only on the plan9 builder.

Updates #31503.

Change-Id: I48ab942ab2894240efe651ec7b7eace7aa5cb45e
Reviewed-on: https://go-review.googlesource.com/c/go/+/172986
Reviewed-by: David du Colombier <0intro@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/link/internal/objfile/objfile.go

index 3de669ee8d8706c3880f81af2ac489b4ab607f56..4f30f58dfc1c3a0f7244e765b8baf35a6bbad7de 100644 (file)
@@ -386,7 +386,9 @@ overwrite:
                        // here is that we get different line numbers on formal
                        // params; I am guessing that the pos is being inherited
                        // from the spot where the wrapper is needed.
-                       whitelist := strings.HasPrefix(dup.Name, "go.info.go.interface")
+                       whitelist := (strings.HasPrefix(dup.Name, "go.info.go.interface") ||
+                               strings.HasPrefix(dup.Name, "go.info.go.builtin") ||
+                               strings.HasPrefix(dup.Name, "go.isstmt.go.builtin"))
                        if !whitelist {
                                r.strictDupMsgs++
                        }