]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: remove unused method needsSniff
authorAbirdcfly <fp544037857@gmail.com>
Mon, 25 Jul 2022 06:31:46 +0000 (06:31 +0000)
committerDamien Neil <dneil@google.com>
Tue, 9 Aug 2022 18:11:37 +0000 (18:11 +0000)
Change-Id: Ia8c67d148fc7e71cac8954ccce6fffb8a6f423df
GitHub-Last-Rev: 9441b8f0c510a3a03dc22816e2616d57f1411965
GitHub-Pull-Request: golang/go#54036
Reviewed-on: https://go-review.googlesource.com/c/go/+/419322
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Javad Rajabzadeh <ja7ad@live.com>
Reviewed-by: hopehook <hopehook@qq.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
src/net/http/response_test.go
src/net/http/server.go

index 5a735b021587d5592218ff8ca4626cb7bfb57efc..2500e420dd55c24458bd56ffe22a935766ea629a 100644 (file)
@@ -972,19 +972,6 @@ func matchErr(err error, wantErr any) error {
        return fmt.Errorf("%v; want %v", err, wantErr)
 }
 
-func TestNeedsSniff(t *testing.T) {
-       // needsSniff returns true with an empty response.
-       r := &response{}
-       if got, want := r.needsSniff(), true; got != want {
-               t.Errorf("needsSniff = %t; want %t", got, want)
-       }
-       // needsSniff returns false when Content-Type = nil.
-       r.handlerHeader = Header{"Content-Type": nil}
-       if got, want := r.needsSniff(), false; got != want {
-               t.Errorf("needsSniff empty Content-Type = %t; want %t", got, want)
-       }
-}
-
 // A response should only write out single Connection: close header. Tests #19499.
 func TestResponseWritesOnlySingleConnectionClose(t *testing.T) {
        const connectionCloseHeader = "Connection: close"
index 960f7d64828278dd84641c5c74b95a8b89b8f26f..f4149e41a32a636d8959ed5aa8047a889183c9e7 100644 (file)
@@ -555,12 +555,6 @@ func (w *response) requestTooLarge() {
        }
 }
 
-// needsSniff reports whether a Content-Type still needs to be sniffed.
-func (w *response) needsSniff() bool {
-       _, haveType := w.handlerHeader["Content-Type"]
-       return !w.cw.wroteHeader && !haveType && w.written < sniffLen
-}
-
 // writerOnly hides an io.Writer value's optional ReadFrom method
 // from io.Copy.
 type writerOnly struct {