]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: remove systemstack logic from adjustframe
authorFelix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Wed, 26 Apr 2023 08:02:22 +0000 (10:02 +0200)
committerCherry Mui <cherryyz@google.com>
Wed, 3 May 2023 14:34:50 +0000 (14:34 +0000)
Remove logic for skipping some adjustframe logic for systemstack (aka
FuncID_systemstack_switch). This was introduced in 2014 by
9198ed4bd6ec7b7dd37aa2797e96f15ddbb1e6cd but doesn't seem to be needed
anymore.

Updates #59692

Change-Id: I2368d64f9bb28ced4e7f15c9b15dac7a29194389
Reviewed-on: https://go-review.googlesource.com/c/go/+/489116
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/runtime/stack.go

index 01d6b9c22ff543554e01db004464a26075741226..45d66da91f659a6e8e0d95a47a35afb0ceba6b6c 100644 (file)
@@ -676,13 +676,6 @@ func adjustframe(frame *stkframe, adjinfo *adjustinfo) {
                adjustpointer(adjinfo, unsafe.Pointer(frame.varp))
        }
 
-       if f.funcID == abi.FuncID_systemstack_switch {
-               // A special routine at the bottom of stack of a goroutine that does a systemstack call.
-               // We will allow it to be copied even though we don't
-               // have full GC info for it (because it is written in asm).
-               return
-       }
-
        locals, args, objs := frame.getStackMap(&adjinfo.cache, true)
 
        // Adjust local variables if stack frame has been allocated.