]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.13] os: re-enable TestPipeThreads on darwin
authorShenghou Ma <minux@golang.org>
Sun, 6 Oct 2019 12:03:44 +0000 (08:03 -0400)
committerAlexander Rakoczy <alex@golang.org>
Wed, 9 Oct 2019 20:24:12 +0000 (20:24 +0000)
CL 197938 actually fixes those regression on Darwin as syscalls
are no longer labeled as always blocking and consume a thread.

Fixes #34712

Change-Id: I82c98516c23cd36f762bc5433d7b71ea8939a0ac
Reviewed-on: https://go-review.googlesource.com/c/go/+/199477
Run-TryBot: Minux Ma <minux@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
(cherry picked from commit cfe232042981972dc0c7e8d741a04556ecaae3c3)
Reviewed-on: https://go-review.googlesource.com/c/go/+/200105
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/os/os_test.go

index 974374ec667b89dbdcc90025298b9d78464b3e70..b94ab0d23209ba802bbc6393d6262b903ad0714e 100644 (file)
@@ -2254,8 +2254,6 @@ func TestPipeThreads(t *testing.T) {
                t.Skip("skipping on Plan 9; does not support runtime poller")
        case "js":
                t.Skip("skipping on js; no support for os.Pipe")
-       case "darwin":
-               t.Skip("skipping on Darwin; issue 33953")
        }
 
        threads := 100