syscall: remove/update outdated TODO comments

Error returns for linux/arm syscalls are handled since a long time.

Remove another list of unimplemented syscalls, following CL 96315.

The root-only check in TestSyscallNoError was shown to be sufficient as
part of CL 84485 already.

NetBSD and OpenBSD do not implement the sendfile syscall (yet), so add a
link to golang.org/issue/5847

Change-Id: I07efc3c3203537a4142707385f31b59dc0ecca42
Reviewed-on: https://go-review.googlesource.com/97115
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

diff --git a/src/syscall/asm_linux_arm.s b/src/syscall/asm_linux_arm.s
index 4463a0f3e78990d1ffd867c94c8b12ad47e035cd..458e9cce797897ff64d821d2283f671a5897b9fa 100644 (file)
--- a/src/syscall/asm_linux_arm.s
+++ b/src/syscall/asm_linux_arm.s
@@ -9,8 +9,6 @@
 // System calls for arm, Linux
 //
 
-// TODO(kaib): handle error returns
-
 // func Syscall(syscall uintptr, a1, a2, a3 uintptr) (r1, r2, err uintptr);
 TEXT ·Syscall(SB),NOSPLIT,$0-28
        BL      runtime·entersyscall(SB)

diff --git a/src/syscall/syscall_bsd.go b/src/syscall/syscall_bsd.go
index d141a7de9d41b712ccdc179e84735264dcbfa022..7337454abed30d6c02060524da8933e45a49c17f 100644 (file)
--- a/src/syscall/syscall_bsd.go
+++ b/src/syscall/syscall_bsd.go
@@ -539,14 +539,6 @@ func Futimes(fd int, tv []Timeval) (err error) {
 
 //sys  fcntl(fd int, cmd int, arg int) (val int, err error)
 
-// TODO: wrap
-//     Acct(name nil-string) (err error)
-//     Gethostuuid(uuid *byte, timeout *Timespec) (err error)
-//     Madvise(addr *byte, len int, behav int) (err error)
-//     Mprotect(addr *byte, len int, prot int) (err error)
-//     Msync(addr *byte, len int, flags int) (err error)
-//     Ptrace(req int, pid int, addr uintptr, data int) (ret uintptr, err error)
-
 var mapper = &mmapper{
        active: make(map[*byte][]byte),
        mmap:   mmap,

diff --git a/src/syscall/syscall_linux_test.go b/src/syscall/syscall_linux_test.go
index becd267101f64858abd903057910b4f1eefe60cf..932ccee491b4bb656c3239046763a62b4c4f7003 100644 (file)
--- a/src/syscall/syscall_linux_test.go
+++ b/src/syscall/syscall_linux_test.go
@@ -180,8 +180,6 @@ func TestSyscallNoError(t *testing.T) {
                t.Skip("skipping on non-32bit architecture")
        }
 
-       // TODO(tklauser) is this check enough? Otherwise test for being in a non-k8s
-       // Linux VM via testenv.Builder().
        if os.Getuid() != 0 {
                t.Skip("skipping root only test")
        }

diff --git a/src/syscall/syscall_netbsd.go b/src/syscall/syscall_netbsd.go
index 06e41894b685861a9dd69fc1d5593967161255f8..18ed885f14ca683d8b7c83b40bd58039f6787f21 100644 (file)
--- a/src/syscall/syscall_netbsd.go
+++ b/src/syscall/syscall_netbsd.go
@@ -142,7 +142,7 @@ func Getdirentries(fd int, buf []byte, basep *uintptr) (n int, err error) {
        return getdents(fd, buf)
 }
 
-// TODO
+// TODO, see golang.org/issue/5847
 func sendfile(outfd int, infd int, offset *int64, count int) (written int, err error) {
        return -1, ENOSYS
 }

diff --git a/src/syscall/syscall_openbsd.go b/src/syscall/syscall_openbsd.go
index 1a9b7644a993dd1a50a9c8e67a8b87d555ca4e2b..db1e9a057f83c0860f60efce7068e146b730bea9 100644 (file)
--- a/src/syscall/syscall_openbsd.go
+++ b/src/syscall/syscall_openbsd.go
@@ -98,7 +98,7 @@ func Getdirentries(fd int, buf []byte, basep *uintptr) (n int, err error) {
        return getdents(fd, buf)
 }
 
-// TODO
+// TODO, see golang.org/issue/5847
 func sendfile(outfd int, infd int, offset *int64, count int) (written int, err error) {
        return -1, ENOSYS
 }