codereview: make sure each mail has a reviewer

R=r
CC=golang-dev
https://golang.org/cl/196050

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 9f7470be527be33ea248e5816d016c905d8f2b5e..a33ea38c061c66b06beb23689e6877a165674c7c 100644 (file)
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -960,8 +960,16 @@ def mail(ui, repo, *pats, **opts):
        if err != "":
                return err
        cl.Upload(ui, repo, gofmt_just_warn=True)
-       if not cl.reviewer and not cl.cc:
-               return "no reviewers listed in CL"
+       if not cl.reviewer:
+               # If no reviewer is listed, assign the review to defaultcc.
+               # This makes sure that it appears in the 
+               # codereview.appspot.com/user/defaultcc
+               # page, so that it doesn't get dropped on the floor.
+               if not defaultcc:
+                       return "no reviewers listed in CL"
+               cl.cc = Sub(cl.cc, defaultcc)
+               cl.reviewer = defaultcc
+               cl.Flush(ui, repo)              
        cl.Mail(ui, repo)
 
 def nocommit(ui, repo, *pats, **opts):