]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: note that some rules know the name of the opt pass
authorJosh Bleecher Snyder <josharian@gmail.com>
Mon, 6 May 2019 01:34:18 +0000 (18:34 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Tue, 7 May 2019 17:43:46 +0000 (17:43 +0000)
Change-Id: I4a70f4a52f84cf50f99939351319504b1c5dff76
Reviewed-on: https://go-review.googlesource.com/c/go/+/175777
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/compile/internal/ssa/compile.go

index 8f9c26d0659dfb2a864be2a47b4b10e914f6c7fb..ce1e7fb409cf616d8ee9b004d11ba908bf89d64c 100644 (file)
@@ -386,7 +386,7 @@ var passes = [...]pass{
        {name: "short circuit", fn: shortcircuit},
        {name: "decompose args", fn: decomposeArgs, required: true},
        {name: "decompose user", fn: decomposeUser, required: true},
-       {name: "opt", fn: opt, required: true},               // TODO: split required rules and optimizing rules
+       {name: "opt", fn: opt, required: true},               // NB: some generic rules know the name of the opt pass. TODO: split required rules and optimizing rules
        {name: "zero arg cse", fn: zcse, required: true},     // required to merge OpSB values
        {name: "opt deadcode", fn: deadcode, required: true}, // remove any blocks orphaned during opt
        {name: "generic cse", fn: cse},