go/types: remove mode argument from the pkgFiles helper

This mode is now always 0. Remove the unnecessary argument to better
align with types2.

Change-Id: Ib59196a9dfc26fd66ae51381eabc760c39ad9ede
Reviewed-on: https://go-review.googlesource.com/c/go/+/442775
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>

diff --git a/src/go/types/errorcalls_test.go b/src/go/types/errorcalls_test.go
index e4164d4beaebfea7aca6874b715b59bd0782ab01..6d6bd6011fc172593c4ae484d28937be7280b927 100644 (file)
--- a/src/go/types/errorcalls_test.go
+++ b/src/go/types/errorcalls_test.go
@@ -16,7 +16,7 @@ const errorfMinArgCount = 4
 // errorfMinArgCount arguments (otherwise we should use check.error).
 func TestErrorCalls(t *testing.T) {
        fset := token.NewFileSet()
-       files, err := pkgFiles(fset, ".", 0)
+       files, err := pkgFiles(fset, ".")
        if err != nil {
                t.Fatal(err)
        }

diff --git a/src/go/types/lookup_test.go b/src/go/types/lookup_test.go
index cd5e3fb13d6119bdc6308d4fc0b00cc3e0128fb2..d3ca58b9fa16f217d3f489e78c3b3aa2b0414438 100644 (file)
--- a/src/go/types/lookup_test.go
+++ b/src/go/types/lookup_test.go
@@ -22,7 +22,7 @@ func BenchmarkLookupFieldOrMethod(b *testing.B) {
        path := filepath.Join(runtime.GOROOT(), "src", "net", "http")
 
        fset := token.NewFileSet()
-       files, err := pkgFiles(fset, path, 0)
+       files, err := pkgFiles(fset, path)
        if err != nil {
                b.Fatal(err)
        }

diff --git a/src/go/types/self_test.go b/src/go/types/self_test.go
index a1af85f27b03609eecc61b71417e81afefbd8dc4..7a1e77083043d2ff5b2d3dae0b15e8cdd344e161 100644 (file)
--- a/src/go/types/self_test.go
+++ b/src/go/types/self_test.go
@@ -19,7 +19,7 @@ import (
 
 func TestSelf(t *testing.T) {
        fset := token.NewFileSet()
-       files, err := pkgFiles(fset, ".", 0)
+       files, err := pkgFiles(fset, ".")
        if err != nil {
                t.Fatal(err)
        }
@@ -61,7 +61,7 @@ func BenchmarkCheck(b *testing.B) {
 
 func runbench(b *testing.B, path string, ignoreFuncBodies, writeInfo bool) {
        fset := token.NewFileSet()
-       files, err := pkgFiles(fset, path, 0)
+       files, err := pkgFiles(fset, path)
        if err != nil {
                b.Fatal(err)
        }
@@ -98,7 +98,7 @@ func runbench(b *testing.B, path string, ignoreFuncBodies, writeInfo bool) {
        b.ReportMetric(float64(lines)*float64(b.N)/time.Since(start).Seconds(), "lines/s")
 }
 
-func pkgFiles(fset *token.FileSet, path string, mode parser.Mode) ([]*ast.File, error) {
+func pkgFiles(fset *token.FileSet, path string) ([]*ast.File, error) {
        filenames, err := pkgFilenames(path) // from stdlib_test.go
        if err != nil {
                return nil, err
@@ -106,7 +106,7 @@ func pkgFiles(fset *token.FileSet, path string, mode parser.Mode) ([]*ast.File,
 
        var files []*ast.File
        for _, filename := range filenames {
-               file, err := parser.ParseFile(fset, filename, nil, mode)
+               file, err := parser.ParseFile(fset, filename, nil, 0)
                if err != nil {
                        return nil, err
                }