go/types, types2: add an assertion that named type origin is idempotent

For #46794

Change-Id: I19edc19640a2dfa6bc7504dd8e1742a261ba29f1
Reviewed-on: https://go-review.googlesource.com/c/go/+/393368
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>

diff --git a/src/cmd/compile/internal/types2/named.go b/src/cmd/compile/internal/types2/named.go
index 8dd9fb6bc40c6c469a88eb2ac556c8e1c9505f07..7b19aeb21f0f2a79d093a38441006ee3d62ff5fc 100644 (file)
--- a/src/cmd/compile/internal/types2/named.go
+++ b/src/cmd/compile/internal/types2/named.go
@@ -78,6 +78,7 @@ func (check *Checker) newNamed(obj *TypeName, orig *Named, underlying Type, tpar
 }
 
 func (t *Named) cleanup() {
+       assert(t.orig.orig == t.orig)
        // Ensure that every defined type created in the course of type-checking has
        // either non-*Named underlying, or is unresolved.
        //

diff --git a/src/go/types/named.go b/src/go/types/named.go
index b8760efc5e0c84129041959ee6b8dc336c28d256..4f855ece822451c2302069bb6e38195b5d45f360 100644 (file)
--- a/src/go/types/named.go
+++ b/src/go/types/named.go
@@ -78,6 +78,7 @@ func (check *Checker) newNamed(obj *TypeName, orig *Named, underlying Type, tpar
 }
 
 func (t *Named) cleanup() {
+       assert(t.orig.orig == t.orig)
        // Ensure that every defined type created in the course of type-checking has
        // either non-*Named underlying, or is unresolved.
        //