cmd/compile: remove vet-blocking hack

...and add the vet failures to the vet whitelist.

Change-Id: Idcf4289f39dda561c85f3b0afe396e5299e6495f
Reviewed-on: https://go-review.googlesource.com/127995
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>

diff --git a/src/cmd/compile/internal/gc/testdata/novet.go b/src/cmd/compile/internal/gc/testdata/novet.go
deleted file mode 100644 (file)
index 0fcbba2..0000000
--- a/src/cmd/compile/internal/gc/testdata/novet.go
+++ /dev/null
@@ -1,9 +0,0 @@
-// Copyright 2018 The Go Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the LICENSE file.
-
-// This file exists just to convince vet not to check this directory.
-// (vet will not check a directory with two different packages in it.)
-// TODO: remove this hack & add failing tests to the whitelist.
-
-package foo

diff --git a/src/cmd/vet/all/whitelist/all.txt b/src/cmd/vet/all/whitelist/all.txt
index 397ee4e9875bc23d5cf390ea75671c0c6963913f..b974d21c6ae236d684aa1d9b6f76599d6a9f00ed 100644 (file)
--- a/src/cmd/vet/all/whitelist/all.txt
+++ b/src/cmd/vet/all/whitelist/all.txt
@@ -28,6 +28,25 @@ encoding/json/tagkey_test.go: struct field tag `:"BadFormat"` not compatible wit
 runtime/testdata/testprog/deadlock.go: unreachable code
 runtime/testdata/testprog/deadlock.go: unreachable code
 
+// Compiler tests that make sure even vet-failing code adheres to the spec.
+cmd/compile/internal/gc/testdata/arithConst_test.go: a (64 bits) too small for shift of 4294967296
+cmd/compile/internal/gc/testdata/arithConst_test.go: a (64 bits) too small for shift of 4294967296
+cmd/compile/internal/gc/testdata/arithConst_test.go: a (32 bits) too small for shift of 4294967295
+cmd/compile/internal/gc/testdata/arithConst_test.go: a (32 bits) too small for shift of 4294967295
+cmd/compile/internal/gc/testdata/arithConst_test.go: a (16 bits) too small for shift of 65535
+cmd/compile/internal/gc/testdata/arithConst_test.go: a (16 bits) too small for shift of 65535
+cmd/compile/internal/gc/testdata/arithConst_test.go: a (8 bits) too small for shift of 255
+cmd/compile/internal/gc/testdata/arithConst_test.go: a (8 bits) too small for shift of 255
+cmd/compile/internal/gc/testdata/arith_test.go: x (64 bits) too small for shift of 100
+cmd/compile/internal/gc/testdata/arith_test.go: int32(x) (32 bits) too small for shift of 4294967295
+cmd/compile/internal/gc/testdata/arith_test.go: int16(x) (16 bits) too small for shift of 65535
+cmd/compile/internal/gc/testdata/arith_test.go: int8(x) (8 bits) too small for shift of 255
+cmd/compile/internal/gc/testdata/arith_test.go: w (32 bits) too small for shift of 32
+cmd/compile/internal/gc/testdata/break_test.go: unreachable code
+cmd/compile/internal/gc/testdata/break_test.go: unreachable code
+cmd/compile/internal/gc/testdata/namedReturn_test.go: self-assignment of t to t
+cmd/compile/internal/gc/testdata/short_test.go: unreachable code
+
 // Non-standard method signatures.
 // These cases are basically ok.
 // Errors are handled reasonably and there's no clear need for interface satisfaction.