]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go/internal/renameio: skip test affected by kernel bug on macOS 10.14 builders
authorBryan C. Mills <bcmills@google.com>
Thu, 5 Mar 2020 16:14:25 +0000 (11:14 -0500)
committerBryan C. Mills <bcmills@google.com>
Thu, 5 Mar 2020 21:42:20 +0000 (21:42 +0000)
The test will remain flaky on the -nocgo builder until #37695 is addressed.

Updates #37695
Fixes #33041

Change-Id: I5d661ef39e82ab1dce3a76e0e4059cf556135e89
Reviewed-on: https://go-review.googlesource.com/c/go/+/222158
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
src/cmd/go/internal/renameio/renameio_test.go

index ee2f3ba1bb8f7f956d88f57d328f7ee9abb18fa4..df8ddabdb821b9b1f6cf8ae8e9250f6523bb35da 100644 (file)
@@ -9,11 +9,13 @@ package renameio
 import (
        "encoding/binary"
        "errors"
+       "internal/testenv"
        "io/ioutil"
        "math/rand"
        "os"
        "path/filepath"
        "runtime"
+       "strings"
        "sync"
        "sync/atomic"
        "syscall"
@@ -24,6 +26,10 @@ import (
 )
 
 func TestConcurrentReadsAndWrites(t *testing.T) {
+       if runtime.GOOS == "darwin" && strings.HasSuffix(testenv.Builder(), "-10_14") {
+               testenv.SkipFlaky(t, 33041)
+       }
+
        dir, err := ioutil.TempDir("", "renameio")
        if err != nil {
                t.Fatal(err)