codereview: fix hang on standard hg commands

R=gri
CC=golang-dev
https://golang.org/cl/1950045

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 3d87f298f4ec72f331721d957b2b206e3aa90ffa..4b03b085f2cf9f739f9fc094506194c5aea9eab9 100644 (file)
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -457,7 +457,9 @@ class StatusThread(threading.Thread):
                        print >>sys.stderr, time.asctime(), s
 
 def start_status_thread():
-       StatusThread().start()
+       t = StatusThread()
+       t.setDaemon(True)  # allowed to exit if t is still running
+       t.start()
 
 class LoadCLThread(threading.Thread):
        def __init__(self, ui, repo, dir, f, web):