]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: add corner cases for readCookiesTests
authorsergey <sngasuan@gmail.com>
Sun, 3 Mar 2019 13:38:04 +0000 (16:38 +0300)
committerEmmanuel Odeke <emm.odeke@gmail.com>
Tue, 5 Mar 2019 22:52:48 +0000 (22:52 +0000)
The following corner cases for readCookiesTests are tested now:
 - An extra cookie delimiter ";" at the end of a Cookie header
 - An empty Cookie header

Change-Id: Id8028b448e4182613fb261bf0903efc98cbf4997
Reviewed-on: https://go-review.googlesource.com/c/go/+/164702
Reviewed-by: Volker Dobler <dr.volker.dobler@gmail.com>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/net/http/cookie_test.go

index 022adaa90def4fa608b62b2d48c0da1906cadb2c..9536a69c20ca3f0f8185bcd3d2fee2b03d99a6aa 100644 (file)
@@ -385,6 +385,19 @@ var readCookiesTests = []struct {
                        {Name: "c2", Value: "v2"},
                },
        },
+       {
+               Header{"Cookie": {`Cookie-1="v$1"; c2=v2;`}},
+               "",
+               []*Cookie{
+                       {Name: "Cookie-1", Value: "v$1"},
+                       {Name: "c2", Value: "v2"},
+               },
+       },
+       {
+               Header{"Cookie": {``}},
+               "",
+               []*Cookie{},
+       },
 }
 
 func TestReadCookies(t *testing.T) {