]> Cypherpunks repositories - gostls13.git/commitdiff
src/go/doc: in Examples, check for len of params.List, not nilness
authorMichael Matloob <matloob@golang.org>
Mon, 16 Dec 2019 22:20:02 +0000 (17:20 -0500)
committerMichael Matloob <matloob@golang.org>
Tue, 17 Dec 2019 17:51:29 +0000 (17:51 +0000)
This makes the check the same as the one in the tests vet check.
It's safer to check the number of arguments rather than for a nil
slice.

Change-Id: I8e04e9c612573f334770c1c4245238649656c6e2
Reviewed-on: https://go-review.googlesource.com/c/go/+/211598
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
src/go/doc/example.go

index 868db8a23fad698a2be5eb0f89645100fb9e9bc6..a010d3a85ab588a324db1dc0b1b6a010b755ee41 100644 (file)
@@ -62,7 +62,7 @@ func Examples(testFiles ...*ast.File) []*Example {
                        if !ok || f.Recv != nil {
                                continue
                        }
-                       if params := f.Type.Params; params.List != nil {
+                       if params := f.Type.Params; len(params.List) != 0 {
                                continue // function has params; not a valid example
                        }
                        numDecl++