The TestMkdirStickyUmask modifies the umask for testing purpose.
When run in parallel with TestCopyFS, this temporary umask change can cause TestCopyFS to create files with unintended permissions, leading to test failures.
This change removes the t.Parallel call in TestMkdirStickyUmask to prevent interference with TestCopyFS, ensuring it doesn't run concurrently with the other tests that require umask.
Fixes #69788
Change-Id: I9cf1da9f92283340ff85d2721781760a750d124c
Reviewed-on: https://go-review.googlesource.com/c/go/+/618055
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
if runtime.GOOS == "wasip1" {
t.Skip("file permissions not supported on " + runtime.GOOS)
}
- t.Parallel()
+ // Issue #69788: This test temporarily changes the umask for testing purposes,
+ // so it shouldn't be run in parallel with other test cases
+ // to avoid other tests (e.g., TestCopyFS) creating files with an unintended umask.
const umask = 0077
dir := t.TempDir()