]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: attach correct line number for fallthru-return
authorDavid Chase <drchase@google.com>
Tue, 8 Mar 2016 18:26:44 +0000 (13:26 -0500)
committerDavid Chase <drchase@google.com>
Tue, 8 Mar 2016 19:23:25 +0000 (19:23 +0000)
Fixes #14646.

Change-Id: I0bb82ed6d3533633cd8369ba37aa467948bbe155
Reviewed-on: https://go-review.googlesource.com/20381
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/compile/internal/gc/ssa.go
test/fixedbugs/issue14646.go [new file with mode: 0644]

index 220e266ccac0acd3557607ea0c45df0e759976ad..b1745a9fc03bd191edfa2dbf0adfa99542dd70ca 100644 (file)
@@ -180,6 +180,7 @@ func buildssa(fn *Node) *ssa.Func {
                s.stmts(s.exitCode)
                m := s.mem()
                b := s.endBlock()
+               b.Line = fn.Func.Endlineno
                b.Kind = ssa.BlockRet
                b.Control = m
        }
diff --git a/test/fixedbugs/issue14646.go b/test/fixedbugs/issue14646.go
new file mode 100644 (file)
index 0000000..96a6854
--- /dev/null
@@ -0,0 +1,23 @@
+// run
+
+// Copyright 2016 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package main
+
+import "runtime"
+
+func main() {
+       var file string
+       var line int
+       func() {
+               defer func() {
+                       _, file, line, _ = runtime.Caller(1)
+               }()
+       }() // this is the expected line
+       const EXPECTED = 18
+       if line != EXPECTED {
+               println("Expected line =", EXPECTED, "but got line =", line, "and file =", file)
+       }
+}