]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: accept smart quotes when checking for missing gold in TestNoteReading
authorMichael Hudson-Doyle <michael.hudson@canonical.com>
Wed, 20 May 2020 02:39:13 +0000 (14:39 +1200)
committerMichael Hudson-Doyle <michael.hudson@canonical.com>
Wed, 20 May 2020 03:40:22 +0000 (03:40 +0000)
Fixes #39157

Change-Id: Ia983f5e66698519cd19c1565cfb80e86d08fdfc6
Reviewed-on: https://go-review.googlesource.com/c/go/+/234380
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/go/note_test.go

index 089e2f33760266af336afe07d85425f73ca5c5e0..659366dcf97bdf4388e7dd6333ca7da7f2499ed7 100644 (file)
@@ -53,7 +53,7 @@ func TestNoteReading(t *testing.T) {
                // we've had trouble reading the notes generated by gold.
                err := tg.doRun([]string{"build", "-ldflags", "-buildid=" + buildID + " -linkmode=external -extldflags=-fuse-ld=gold", "-o", tg.path("hello3.exe"), tg.path("hello.go")})
                if err != nil {
-                       if tg.grepCountBoth("(invalid linker|gold|cannot find 'ld')") > 0 {
+                       if tg.grepCountBoth("(invalid linker|gold|cannot find [‘']ld[’'])") > 0 {
                                // It's not an error if gold isn't there. gcc claims it "cannot find 'ld'" if
                                // ld.gold is missing, see issue #22340.
                                t.Log("skipping gold test")