Ignore some noisy warnings

diff --git a/cyac/.clang-tidy b/cyac/.clang-tidy
index 486254dc7aaac37f216d2205ebaf2688e5004add143db0c70fd19a67d349ee68..393e26bbb600e0c7c25e951d74a37427e1162cb7ae5cbdd1a31de4e0ea1a8422 100644 (file)
--- a/cyac/.clang-tidy
+++ b/cyac/.clang-tidy
@@ -6,7 +6,9 @@ Checks: "
     -bugprone-easily-swappable-parameters,
     -cert-err33-c,
     -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
+    -concurrency-mt-unsafe,
     -cppcoreguidelines-avoid-magic-numbers,
+    -cppcoreguidelines-avoid-non-const-global-variables,
     -llvm-header-guard,
     -llvmlibc-restrict-system-libc-headers,
     -readability-*,

diff --git a/cyac/cmd/cer-verify/cer-verify.c b/cyac/cmd/cer-verify/cer-verify.c
index f77b91a7019179c09c6a2cddbdf5c952c83ac5710146e97cc7f7d5991b652d80..e31e3dfcbc3420ed943ec28f47d4086223be91aa33bdb9935036181cbef942c3 100644 (file)
--- a/cyac/cmd/cer-verify/cer-verify.c
+++ b/cyac/cmd/cer-verify/cer-verify.c
@@ -44,12 +44,8 @@ main(int argc, char **argv)
         unsigned char *buf = NULL;
         size_t len = 0;
         if (!Mmap(&buf, &len, argv[i])) {
-            fprintf(
-                stderr,
-                "%s: %s\n",
-                argv[i],
-                strerror(errno)); // NOLINT(concurrency-mt-unsafe)
-            exit(EXIT_FAILURE);   // NOLINT(concurrency-mt-unsafe)
+            fprintf(stderr, "%s: %s\n", argv[i], strerror(errno));
+            exit(EXIT_FAILURE);
         }
         fputs(argv[i], stdout);
         fputs(":\t", stdout);
@@ -71,7 +67,7 @@ main(int argc, char **argv)
     struct timespec now;
     errno = 0;
     if (clock_gettime(CLOCK_REALTIME, &now) != 0) {
-        fprintf(stderr, "%s\n", strerror(errno)); // NOLINT(concurrency-mt-unsafe)
+        fprintf(stderr, "%s\n", strerror(errno));
         return EXIT_FAILURE;
     }
 

diff --git a/cyac/cmd/lib/mmap.c b/cyac/cmd/lib/mmap.c
index d3d3a2f9ad2a6243a7906da5c81ca40c50c205bb11978f5ccede537fa1897ea2..9f533799830bd81b962ce5b0bf510a185a7f26a689d6e4c621e901945a976363 100644 (file)
--- a/cyac/cmd/lib/mmap.c
+++ b/cyac/cmd/lib/mmap.c
@@ -25,7 +25,7 @@ Mmap(unsigned char **buf, size_t *len, const char *path)
     errno = 0;
     (*buf) = mmap(NULL, *len, PROT_READ, MAP_SHARED, fd, 0);
     if ((*buf) == MAP_FAILED) { // NOLINT(performance-no-int-to-ptr)
-        fprintf(stderr, "mmap: %s\n", strerror(errno)); // NOLINT(concurrency-mt-unsafe)
+        fprintf(stderr, "mmap: %s\n", strerror(errno));
         return false;
     }
     return true;

diff --git a/cyac/cmd/lib/printai.c b/cyac/cmd/lib/printai.c
index 8e2ffd224f119f285dbe988ac21793c04d7fdbd33cb511812242feb396ecb1d9..f8ae8842844778a061b1aa1a4fa1c5f87aa13fa5b2a810621fe2a938c23975ca 100644 (file)
--- a/cyac/cmd/lib/printai.c
+++ b/cyac/cmd/lib/printai.c
@@ -61,7 +61,7 @@ PrintTAI64(const unsigned char *buf, const size_t len)
         return err;
     }
     time_t t = tv.tv_sec;
-    struct tm *tm = localtime(&t); // NOLINT(concurrency-mt-unsafe)
+    struct tm *tm = localtime(&t);
     if (tm == NULL) {
         hex = HexEnc(buf, len);
         fprintf(stdout, "unrepresentable: %s)\n", hex);

diff --git a/cyac/cmd/print-itered/print-itered.c b/cyac/cmd/print-itered/print-itered.c
index 90fd10dc19af02ae16902f3e0a5c444068c62b01d6035cc4f5ecffb00e318d3a..7fcaf54dd68df096bf84d25f9c67b82ae6db5e03e181b73d241b7f22605bfc6b 100644 (file)
--- a/cyac/cmd/print-itered/print-itered.c
+++ b/cyac/cmd/print-itered/print-itered.c
@@ -163,7 +163,7 @@ main(int argc, char **argv)
     size_t len = 0;
     unsigned char *buf = NULL;
     if (!Mmap(&buf, &len, argv[1])) {
-        exit(EXIT_FAILURE); // NOLINT(concurrency-mt-unsafe)
+        exit(EXIT_FAILURE);
     }
     struct YACAtom atom;
     memset(&atom, 0, sizeof(struct YACAtom));

diff --git a/cyac/cmd/test-vector/test-vector.c b/cyac/cmd/test-vector/test-vector.c
index 2d7b1cf14650fade45b3156d0f546a4662031688f3e65ca463cb86fdee910750..42a3b98bcc199f82afd9c13393a22c3477ef5d0f85e0eb8ab076529542de0f4a 100644 (file)
--- a/cyac/cmd/test-vector/test-vector.c
+++ b/cyac/cmd/test-vector/test-vector.c
@@ -10,8 +10,8 @@
 #include <yac/enc.h>
 #include <yac/enctai.h>
 
-static size_t Off = 0; // NOLINT(cppcoreguidelines-avoid-non-const-global-variables)
-static size_t Got = 0; // NOLINT(cppcoreguidelines-avoid-non-const-global-variables)
+static size_t Off = 0;
+static size_t Got = 0;
 
 static void
 adder(const bool ok)