lib/codereview/codereview.py: fix crash when hg gofmt has no files

The gofmt function was returning a string, which isn't the right type.
Three cheers for dynamic typing.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7917044

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 11766fcb23a76836042ff463947083bb7fd2c8e9..f839263c55746442ff25fcf5482ebb699ec8861d 100644 (file)
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -1762,7 +1762,8 @@ def gofmt(ui, repo, *pats, **opts):
        files = ChangedExistingFiles(ui, repo, pats, opts)
        files = gofmt_required(files)
        if not files:
-               return "no modified go files"
+               ui.status("no modified go files\n")
+               return
        cwd = os.getcwd()
        files = [RelativePath(repo.root + '/' + f, cwd) for f in files]
        try: