]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist: skip static linking tests for linux boringcrypto
authorIan Lance Taylor <iant@golang.org>
Tue, 4 Apr 2023 21:43:46 +0000 (14:43 -0700)
committerGopher Robot <gobot@golang.org>
Wed, 5 Apr 2023 00:47:58 +0000 (00:47 +0000)
Otherwise we get warnings from the C linker.

Fixes #59422

Change-Id: I61843dbe5245da0185b0f23dc4b774767fffed40
Reviewed-on: https://go-review.googlesource.com/c/go/+/482315
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
src/cmd/dist/test.go

index a52457efccdc677eef69069095faba39e30e5dd1..fa03068350df26d6990eb0e90e7324e623de0e49 100644 (file)
@@ -1266,6 +1266,17 @@ func (t *tester) registerCgoTests() {
                                }
                        }
 
+                       // Doing a static link with boringcrypto gets
+                       // a C linker warning on Linux.
+                       // in function `bio_ip_and_port_to_socket_and_addr':
+                       // warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
+                       if staticCheck.pre == nil && goos == "linux" && strings.Contains(goexperiment, "boringcrypto") {
+                               staticCheck.pre = func(*distTest) bool {
+                                       fmt.Println("skipping static linking check on Linux when using boringcrypto to avoid C linker warning about getaddrinfo")
+                                       return false
+                               }
+                       }
+
                        // Static linking tests
                        if goos != "android" && p != "netbsd/arm" {
                                // TODO(#56629): Why does this fail on netbsd-arm?