]> Cypherpunks repositories - gostls13.git/commitdiff
compress/gzip: skip builder-only test on iOS
authorElias Naur <elias.naur@gmail.com>
Fri, 4 May 2018 08:17:30 +0000 (10:17 +0200)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 4 May 2018 14:46:19 +0000 (14:46 +0000)
The new iOS test harness forwards environment variables to the
test program, which means that it runs builder-only tests that were
previously skipped because GO_BUILDER_NAME was missing.

Skip one such unblocked test, TestGZIPFilesHaveZeroMTimes, which
assumes a valid GOROOT.

Change-Id: I5daf0f4c1897afbeb8b1a380669a1d2aa47e764a
Reviewed-on: https://go-review.googlesource.com/111475
Run-TryBot: Elias Naur <elias.naur@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/compress/gzip/issue14937_test.go

index 30c1390dfd7faf0ca4d2e1e37c8868db2f9e2089..7a19672d578f6744abc1754ea376f824572c88ca 100644 (file)
@@ -21,6 +21,10 @@ func TestGZIPFilesHaveZeroMTimes(t *testing.T) {
        if testenv.Builder() == "" {
                t.Skip("skipping test on non-builder")
        }
+       if !testenv.HasSrc() {
+               t.Skip("skipping; no GOROOT available")
+       }
+
        goroot, err := filepath.EvalSymlinks(runtime.GOROOT())
        if err != nil {
                t.Fatal("error evaluating GOROOT: ", err)